hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell" <apurt...@apache.org>
Subject Re: Review Request: Support alternate compression for major compactions
Date Tue, 14 Sep 2010 03:20:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/821/
-----------------------------------------------------------

(Updated 2010-09-13 20:20:49.489804)


Review request for hbase.


Changes
-------

Updated diff to handle dumb NPE pointed out by tlipcon, also addresses the same problem in
existing code.


Summary
-------

Support alternate compression for major compactions.

This is expected to be an uncommmon configuration so I did not pollute the HColumnDescriptor
constructor with the new option; instead only added convenience {get,set}ters.


This addresses bug HBASE-2988.
    http://issues.apache.org/jira/browse/HBASE-2988


Diffs (updated)
-----

  src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java 8e3bd53 
  src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 4f777f0 
  src/main/ruby/hbase/admin.rb 82d7e54 

Diff: http://review.cloudera.org/r/821/diff


Testing
-------

Created table with LZO compression, inserted 10GB of data, altered schema with COMPRESSION_COMPACT
of 'LZMA' (custom LZMA Hadoop compression plugin), initiated major compaction, confirmed the
results by examining HFiles on local fs with the UNIX file utility.


Thanks,

Andrew


Mime
View raw message