hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: Refactor CLI parsing out of HRegionServer
Date Mon, 13 Sep 2010 18:33:23 GMT


> On 2010-09-10 08:42:41, stack wrote:
> > src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java, line 48
> > <http://review.cloudera.org/r/812/diff/1/?file=11389#file11389line48>
> >
> >     Daemon is a good name but maybe use the not so good 'ServerCommandLine' so it
aligns w/ the new Server Interface we extracted from Master and RS
> >     
> >     Or we could change the 'Server' Interface name to Daemon?
> 
> Todd Lipcon wrote:
>     Will change to ServerCommandLine like you suggested. Want to re-review the change
or shall I just commit when fixed?

Just commit.  No need of re-review.  Thanks Todd.


- stack


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/812/#review1151
-----------------------------------------------------------


On 2010-09-13 11:29:19, Todd Lipcon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/812/
> -----------------------------------------------------------
> 
> (Updated 2010-09-13 11:29:19)
> 
> 
> Review request for hbase, stack and Jonathan Gray.
> 
> 
> Summary
> -------
> 
> Same as HBASE-2977 but from the master side
> 
> 
> This addresses bug HBASE-2980.
>     http://issues.apache.org/jira/browse/HBASE-2980
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/master/HMaster.java 792fb3e 
>   src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java 6421808 
>   src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1e046f9 
>   src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServerCommandLine.java PRE-CREATION

>   src/main/java/org/apache/hadoop/hbase/util/ServerCommandLine.java PRE-CREATION 
>   src/test/java/org/apache/hadoop/hbase/master/OOMEHMaster.java b51e6ab 
>   src/test/java/org/apache/hadoop/hbase/regionserver/OOMERegionServer.java c591632 
> 
> Diff: http://review.cloudera.org/r/812/diff
> 
> 
> Testing
> -------
> 
> Started a region server, also checked usage info for a bad param.
> 
> 
> Thanks,
> 
> Todd
> 
>


Mime
View raw message