Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 76092 invoked from network); 25 Aug 2010 20:20:17 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 25 Aug 2010 20:20:17 -0000 Received: (qmail 21805 invoked by uid 500); 25 Aug 2010 20:20:17 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 21670 invoked by uid 500); 25 Aug 2010 20:20:16 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 21662 invoked by uid 99); 25 Aug 2010 20:20:16 -0000 Received: from Unknown (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Aug 2010 20:20:16 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of jdcryans@gmail.com designates 74.125.82.41 as permitted sender) Received: from [74.125.82.41] (HELO mail-ww0-f41.google.com) (74.125.82.41) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Aug 2010 20:19:54 +0000 Received: by wwb18 with SMTP id 18so1444663wwb.2 for ; Wed, 25 Aug 2010 13:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:content-type:content-transfer-encoding; bh=RICIzpAA36upoHBuRvol0AffXMcwHw08sd5sz1qA+ds=; b=q6wR2lBGrQ6chBqecI6FX0Gx6xRVp3dNnuZnoM3Fua9XvRkTF01EDReg4dBz4bGyE5 +rtN6P4yJnAB+z5SVJRYyttfruhsrhtbV5YtfJlBtnGiEhUcJobxyZlEPgNOcX1nV6xU vkva37qrixGFtK8MLX65RkkWsMrC9s5fsbwOY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=sg4H7vmTi7SLhjT8k3r8ACMG2jY+YLbN1Aic0SxBq+24Db+kgUpY16LNT1UXsDm87E uAeJ11ZNElqcds8/SCncoQtRFnV926xWJC+qEVPCGdF9cmJ6v6TKEA1U5voQdzmxkD5e JHBZdodn7NW40oN07J4SHRs5gjYXC/0nwDm8c= MIME-Version: 1.0 Received: by 10.216.17.135 with SMTP id j7mr7812229wej.97.1282767573882; Wed, 25 Aug 2010 13:19:33 -0700 (PDT) Sender: jdcryans@gmail.com Received: by 10.216.4.84 with HTTP; Wed, 25 Aug 2010 13:19:33 -0700 (PDT) In-Reply-To: References: <20100825185756.27362.57859@ip-10-202-7-187.ec2.internal> Date: Wed, 25 Aug 2010 13:19:33 -0700 X-Google-Sender-Auth: u3xisG1uRpPVCyhocw0tGWODV_o Message-ID: Subject: Re: Review Request: RegionServer should refuse to be assigned a region that use LZO when LZO isn't available From: Jean-Daniel Cryans To: dev@hbase.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org Sure, but currently there's no infrastructure for that. It could be part of the master rewrite, but it'd be low priority as we are still in the process of having a functional master. Also we need that kind of reporting outside of the web UIs as some production environment may not have those. J-D On Wed, Aug 25, 2010 at 1:11 PM, Ted Yu wrote: > Can we display region server(s) which has this issue in a different color= in > Region Servers table on master.jsp ? > Or better, can we add a column showing brief error message in Region Serv= ers > table ? > > On Wed, Aug 25, 2010 at 11:57 AM, Jean-Daniel Cryans wrote: > >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://review.cloudera.org/r/719/ >> ----------------------------------------------------------- >> >> Review request for hbase. >> >> >> Summary >> ------- >> >> Trying to make some progress on this issue, here's an untested patch tha= t >> adds testing of codecs when the region server starts, then uses that to >> check the schema of regions it tries to open. That's basically what this >> jira's scope is about. >> >> Some things I don't like the way I did it: >> =A0- For all the users that don't do LZO, they will have a WARN every ti= me a >> RS starts (in its log) >> =A0- Does not cover cases where the files are LZOed, but the schema is N= ONE >> or GZ >> >> Finally, there's no way to let user know about the errors unless he chec= ks >> the logs, but a least we won't throw ugly exceptions. >> >> >> This addresses bug HBASE-2514. >> =A0 =A0http://issues.apache.org/jira/browse/HBASE-2514 >> >> >> Diffs >> ----- >> >> =A0/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServ= er.java >> 989204 >> =A0/trunk/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.jav= a >> 989204 >> >> Diff: http://review.cloudera.org/r/719/diff >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Jean-Daniel >> >> >