Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 41426 invoked from network); 20 Aug 2010 23:24:05 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 20 Aug 2010 23:24:05 -0000 Received: (qmail 29935 invoked by uid 500); 20 Aug 2010 23:24:05 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 29871 invoked by uid 500); 20 Aug 2010 23:24:05 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 29863 invoked by uid 99); 20 Aug 2010 23:24:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Aug 2010 23:24:04 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: 184.73.217.71 is neither permitted nor denied by domain of stack@duboce.net) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Aug 2010 23:23:59 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id E96528A1EA; Fri, 20 Aug 2010 23:23:38 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HLog cleanup is done under the updateLock, major slowdown From: stack@duboce.net To: "Jean-Daniel Cryans" , jiraposter@review.hbase.org, dev@hbase.apache.org, stack@duboce.net Date: Fri, 20 Aug 2010 23:23:38 -0000 Message-ID: <20100820232338.25773.33390@ip-10-202-7-187.ec2.internal> In-Reply-To: <20100820225827.25772.49543@ip-10-202-7-187.ec2.internal> References: <20100820225827.25772.49543@ip-10-202-7-187.ec2.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/694/#review980 ----------------------------------------------------------- Ship it! OK +1 - stack On 2010-08-20 15:58:27, Jean-Daniel Cryans wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/694/ > ----------------------------------------------------------- > = > (Updated 2010-08-20 15:58:27) > = > = > Review request for hbase. > = > = > Summary > ------- > = > Simply moves the LogActionListeners and outputfiles handling out of the u= pdateLock synchronization, as well as the creation of the next log file. > = > = > This addresses bug HBASE-2922. > http://issues.apache.org/jira/browse/HBASE-2922 > = > = > Diffs > ----- > = > /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java= 987355 = > = > Diff: http://review.cloudera.org/r/694/diff > = > = > Testing > ------- > = > Unit tests and some PEs. > = > = > Thanks, > = > Jean-Daniel > = >