Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 36727 invoked from network); 20 Aug 2010 23:09:29 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 20 Aug 2010 23:09:29 -0000 Received: (qmail 13465 invoked by uid 500); 20 Aug 2010 23:09:29 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 13442 invoked by uid 500); 20 Aug 2010 23:09:29 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Delivered-To: moderator for dev@hbase.apache.org Received: (qmail 9408 invoked by uid 99); 20 Aug 2010 22:59:09 -0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HLog cleanup is done under the updateLock, major slowdown From: "Jean-Daniel Cryans" To: "Jean-Daniel Cryans" , jiraposter@review.hbase.org, dev@hbase.apache.org Date: Fri, 20 Aug 2010 22:58:27 -0000 Message-ID: <20100820225827.25772.49543@ip-10-202-7-187.ec2.internal> In-Reply-To: <20100820225117.25772.79709@ip-10-202-7-187.ec2.internal> References: <20100820225117.25772.79709@ip-10-202-7-187.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/694/ ----------------------------------------------------------- (Updated 2010-08-20 15:58:27.771023) Review request for hbase. Summary (updated) ------- Simply moves the LogActionListeners and outputfiles handling out of the upd= ateLock synchronization, as well as the creation of the next log file. This addresses bug HBASE-2922. http://issues.apache.org/jira/browse/HBASE-2922 Diffs ----- /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 9= 87355 = Diff: http://review.cloudera.org/r/694/diff Testing ------- Unit tests and some PEs. Thanks, Jean-Daniel