Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: Review Request: HBASE-50: Snapshot of table
From: "Chongxin Li" <lichongxin@zju.edu.cn>
To: "Ted Yu" <ted_yu@yahoo.com>, "Chongxin Li" <lichongxin@zju.edu.cn>,
	"Todd Lipcon" <todd@cloudera.com>, dev@hbase.apache.org,
	stack@duboce.net, jiraposter@review.hbase.org
Date: Thu, 19 Aug 2010 15:35:37 -0000
Message-ID: <20100819153537.25773.54786@ip-10-202-7-187.ec2.internal>
In-Reply-To: <20100814083001.19917.91827@ip-10-202-7-187.ec2.internal>
References: <20100814083001.19917.91827@ip-10-202-7-187.ec2.internal>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/467/
-----------------------------------------------------------

(Updated 2010-08-19 08:35:37.043957)


Review request for hbase.


Summary
-------

This patch includes the first three sub-tasks of HBASE-50:
1. Start and monitor the creation of snapshot via ZooKeeper
2. Create snapshot of an HBase table
3. Some existing functions of HBase are modified to support snapshot

Currently snapshots can be created as expected, but can not be restored or =
deleted yet


This addresses bug HBASE-50.
    http://issues.apache.org/jira/browse/HBASE-50


Diffs (updated)
-----

  bin/add_snapshot_family.rb PRE-CREATION =

  src/main/java/org/apache/hadoop/hbase/HConstants.java c77ebf5 =

  src/main/java/org/apache/hadoop/hbase/HRegionInfo.java ee94690 =

  src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java 0d57270 =

  src/main/java/org/apache/hadoop/hbase/SnapshotDescriptor.java PRE-CREATIO=
N =

  src/main/java/org/apache/hadoop/hbase/SnapshotExistsException.java PRE-CR=
EATION =

  src/main/java/org/apache/hadoop/hbase/TablePartiallyOpenException.java PR=
E-CREATION =

  src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 8b01aa0 =

  src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java ed12e7a =

  src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 85fde3a =

  src/main/java/org/apache/hadoop/hbase/io/Reference.java 219203c =

  src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java b2de7e4 =

  src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPCProtocolVersion.java d4=
bcbed =

  src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java bd48a4b =

  src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.jav=
a 1183584 =

  src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java 69eab39 =

  src/main/java/org/apache/hadoop/hbase/master/DeleteSnapshot.java PRE-CREA=
TION =

  src/main/java/org/apache/hadoop/hbase/master/HMaster.java e4bd30d =

  src/main/java/org/apache/hadoop/hbase/master/LogsCleaner.java 9d1a8b8 =

  src/main/java/org/apache/hadoop/hbase/master/RestoreSnapshot.java PRE-CRE=
ATION =

  src/main/java/org/apache/hadoop/hbase/master/SnapshotLogCleaner.java PRE-=
CREATION =

  src/main/java/org/apache/hadoop/hbase/master/SnapshotMonitor.java PRE-CRE=
ATION =

  src/main/java/org/apache/hadoop/hbase/master/SnapshotOperation.java PRE-C=
REATION =

  src/main/java/org/apache/hadoop/hbase/master/SnapshotSentinel.java PRE-CR=
EATION =

  src/main/java/org/apache/hadoop/hbase/master/TableDelete.java 1153e62 =

  src/main/java/org/apache/hadoop/hbase/master/TableSnapshot.java PRE-CREAT=
ION =

  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6dc41a4 =

  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 6a5=
4736 =

  src/main/java/org/apache/hadoop/hbase/regionserver/Snapshotter.java PRE-C=
REATION =

  src/main/java/org/apache/hadoop/hbase/regionserver/Store.java ae9e190 =

  src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 757a50c =

  src/main/java/org/apache/hadoop/hbase/regionserver/ZKSnapshotWatcher.java=
 PRE-CREATION =

  src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 9593286 =

  src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCl=
eaner.java 4d4b00a =

  src/main/java/org/apache/hadoop/hbase/util/FSUtils.java 5cf3481 =

  src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java 382=
7fa5 =

  src/main/resources/hbase-default.xml b73f0ff =

  src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 4d09fe9 =

  src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java c9b78b9 =

  src/test/java/org/apache/hadoop/hbase/master/TestLogsCleaner.java 8b7f60f =

  src/test/java/org/apache/hadoop/hbase/master/TestSnapshot.java PRE-CREATI=
ON =

  src/test/java/org/apache/hadoop/hbase/master/TestSnapshotFailure.java PRE=
-CREATION =

  src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java 34=
b8044 =

  src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 98bd3=
e5 =

  src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionSnapshot.ja=
va PRE-CREATION =

  src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java 38e=
f520 =

  src/test/java/org/apache/hadoop/hbase/regionserver/TestZKSnapshotWatcher.=
java PRE-CREATION =


Diff: http://review.cloudera.org/r/467/diff


Testing
-------

Unit tests and integration tests with mini cluster passed.


Thanks,

Chongxin