hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Rawson <ryano...@gmail.com>
Subject Re: Why does FilterList inherit from Filter and not from FilterBase? Any particular reason?
Date Wed, 11 Aug 2010 05:49:00 GMT
Filter is a large interface requiring something like 6-7 methods to be
defined.  Furthermore, nearly all of those methods have a reasonable
default for a 'null filter' that would filter nothing.  That is what
FilterBase does.

FilterList overrides every single interface method, thus it doesn't
need FilterBase. One could make it derive from FilterBase, but that
relationship would neither communicate any design statements (eg: a
FilterList ISA FilterBase is not relevant), nor would it provide
useful base implementation.

If you think it's more important to be consistent, it wouldn't hurt to
inherit from FilterBase.


On Tue, Aug 10, 2010 at 9:44 PM, Stack <stack@duboce.net> wrote:
> See subject.
> If not, ok if we fix this?
> Thanks,
> St.Ack

View raw message