hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ted Yu <yuzhih...@gmail.com>
Subject Re: Review Request: HBASE-50: Snapshot of table
Date Thu, 12 Aug 2010 16:15:40 GMT
Here are other choices for SnapshotTracker (see
http://freethesaurus.net/s.php?q=watcher):
SnapshotObserver, SnapshotSentinel

I prefer the second one.

For HBase root directory:
        HBaseConfiguration conf = new HBaseConfiguration();
        String rootDir = conf.get("hbase.rootdir");

On Thu, Aug 12, 2010 at 5:53 AM, Chongxin Li <lichongxin@zju.edu.cn> wrote:

>
>
> > On 2010-08-12 02:53:06, Ted Yu wrote:
> > > src/main/java/org/apache/hadoop/hbase/master/SnapshotTracker.java, line
> 1
> > > <http://review.cloudera.org/r/467/diff/3/?file=6021#file6021line1>
> > >
> > >     How about SnapshotWatcher ?
>
> Will it sound like this class implement the Watcher interface of ZK?
>
>
> > On 2010-08-12 02:53:06, Ted Yu wrote:
> > > src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java, line
> 283
> > > <http://review.cloudera.org/r/467/diff/3/?file=6028#file6028line283>
> > >
> > >     Can we get to hbase root directly ?
>
> Since this method is static, we probably need another parameter for root
> directory?
>
>
> - Chongxin
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/467/#review869
> -----------------------------------------------------------
>
>
> On 2010-08-12 02:43:42, Chongxin Li wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://review.cloudera.org/r/467/
> > -----------------------------------------------------------
> >
> > (Updated 2010-08-12 02:43:42)
> >
> >
> > Review request for hbase.
> >
> >
> > Summary
> > -------
> >
> > This patch includes the first three sub-tasks of HBASE-50:
> > 1. Start and monitor the creation of snapshot via ZooKeeper
> > 2. Create snapshot of an HBase table
> > 3. Some existing functions of HBase are modified to support snapshot
> >
> > Currently snapshots can be created as expected, but can not be restored
> or deleted yet
> >
> >
> > This addresses bug HBASE-50.
> >     http://issues.apache.org/jira/browse/HBASE-50
> >
> >
> > Diffs
> > -----
> >
> >   src/main/java/org/apache/hadoop/hbase/HConstants.java c77ebf5
> >   src/main/java/org/apache/hadoop/hbase/HRegionInfo.java ee94690
> >   src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java 0d57270
> >   src/main/java/org/apache/hadoop/hbase/SnapshotDescriptor.java
> PRE-CREATION
> >   src/main/java/org/apache/hadoop/hbase/SnapshotExistsException.java
> PRE-CREATION
> >   src/main/java/org/apache/hadoop/hbase/TablePartiallyOpenException.java
> PRE-CREATION
> >   src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 8b01aa0
> >   src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
> ed12e7a
> >   src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
> 85fde3a
> >   src/main/java/org/apache/hadoop/hbase/io/Reference.java 219203c
> >   src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java b2de7e4
> >   src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPCProtocolVersion.java
> d4bcbed
> >   src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java bd48a4b
> >
> src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java
> 1183584
> >   src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java 69eab39
> >   src/main/java/org/apache/hadoop/hbase/master/DeleteSnapshot.java
> PRE-CREATION
> >   src/main/java/org/apache/hadoop/hbase/master/HMaster.java e4bd30d
> >   src/main/java/org/apache/hadoop/hbase/master/LogsCleaner.java 9d1a8b8
> >   src/main/java/org/apache/hadoop/hbase/master/RestoreSnapshot.java
> PRE-CREATION
> >   src/main/java/org/apache/hadoop/hbase/master/SnapshotLogCleaner.java
> PRE-CREATION
> >   src/main/java/org/apache/hadoop/hbase/master/SnapshotMonitor.java
> PRE-CREATION
> >   src/main/java/org/apache/hadoop/hbase/master/SnapshotOperation.java
> PRE-CREATION
> >   src/main/java/org/apache/hadoop/hbase/master/SnapshotTracker.java
> PRE-CREATION
> >   src/main/java/org/apache/hadoop/hbase/master/TableDelete.java 1153e62
> >   src/main/java/org/apache/hadoop/hbase/master/TableSnapshot.java
> PRE-CREATION
> >   src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6dc41a4
> >   src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> 6a54736
> >   src/main/java/org/apache/hadoop/hbase/regionserver/Snapshotter.java
> PRE-CREATION
> >   src/main/java/org/apache/hadoop/hbase/regionserver/Store.java ae9e190
> >   src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
> 757a50c
> >
> src/main/java/org/apache/hadoop/hbase/regionserver/ZKSnapshotWatcher.java
> PRE-CREATION
> >   src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
> 9593286
> >
> src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java
> 4d4b00a
> >   src/main/java/org/apache/hadoop/hbase/util/FSUtils.java 5cf3481
> >   src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java
> 3827fa5
> >   src/main/resources/hbase-default.xml b73f0ff
> >   src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 4d09fe9
> >   src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java c9b78b9
> >   src/test/java/org/apache/hadoop/hbase/master/TestLogsCleaner.java
> 8b7f60f
> >   src/test/java/org/apache/hadoop/hbase/master/TestSnapshot.java
> PRE-CREATION
> >   src/test/java/org/apache/hadoop/hbase/master/TestSnapshotFailure.java
> PRE-CREATION
> >   src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
> 34b8044
> >   src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
> 98bd3e5
> >
> src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionSnapshot.java
> PRE-CREATION
> >   src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java
> 38ef520
> >
> src/test/java/org/apache/hadoop/hbase/regionserver/TestZKSnapshotWatcher.java
> PRE-CREATION
> >
> > Diff: http://review.cloudera.org/r/467/diff
> >
> >
> > Testing
> > -------
> >
> > Unit tests and integration tests with mini cluster passed.
> >
> >
> > Thanks,
> >
> > Chongxin
> >
> >
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message