hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: HLog cleanup is done under the updateLock, major slowdown
Date Fri, 20 Aug 2010 23:23:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/694/#review980
-----------------------------------------------------------

Ship it!


OK

+1

- stack


On 2010-08-20 15:58:27, Jean-Daniel Cryans wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/694/
> -----------------------------------------------------------
> 
> (Updated 2010-08-20 15:58:27)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> Simply moves the LogActionListeners and outputfiles handling out of the updateLock synchronization,
as well as the creation of the next log file.
> 
> 
> This addresses bug HBASE-2922.
>     http://issues.apache.org/jira/browse/HBASE-2922
> 
> 
> Diffs
> -----
> 
>   /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 987355 
> 
> Diff: http://review.cloudera.org/r/694/diff
> 
> 
> Testing
> -------
> 
> Unit tests and some PEs.
> 
> 
> Thanks,
> 
> Jean-Daniel
> 
>


Mime
View raw message