hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: HLog cleanup is done under the updateLock, major slowdown
Date Fri, 20 Aug 2010 23:08:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/694/#review976
-----------------------------------------------------------



/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
<http://review.cloudera.org/r/694/#comment3169>

    This is an invariant?  Will multiple threads arriving here at same time pickup same filenum?



/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
<http://review.cloudera.org/r/694/#comment3168>

    Should this be inside the update lock?  If many threads, each will create a writer?  Or
is thought that this is mostly single-threaded and that if multiple threads arrive here at
same time, its unusual and just let each roll?



/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
<http://review.cloudera.org/r/694/#comment3170>

    Yeah, should this be inside the update lock so many concurrent threads don't all create
instances of these streams?



/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
<http://review.cloudera.org/r/694/#comment3172>

    Yes, this should be outside of the sync block.



/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
<http://review.cloudera.org/r/694/#comment3171>

    Yeah, is this safe?  If two threads come in here at same time, they proceed in series
but when the second gets to here he's going to claim he rolled the wrong old file?


- stack


On 2010-08-20 15:58:27, Jean-Daniel Cryans wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/694/
> -----------------------------------------------------------
> 
> (Updated 2010-08-20 15:58:27)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> Simply moves the LogActionListeners and outputfiles handling out of the updateLock synchronization,
as well as the creation of the next log file.
> 
> 
> This addresses bug HBASE-2922.
>     http://issues.apache.org/jira/browse/HBASE-2922
> 
> 
> Diffs
> -----
> 
>   /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 987355 
> 
> Diff: http://review.cloudera.org/r/694/diff
> 
> 
> Testing
> -------
> 
> Unit tests and some PEs.
> 
> 
> Thanks,
> 
> Jean-Daniel
> 
>


Mime
View raw message