hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Georgiev" <espr1t....@gmail.com>
Subject Re: Review Request: Improvements to HBaseFsck tool
Date Wed, 18 Aug 2010 23:50:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/418/#review955
-----------------------------------------------------------



src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java
<http://review.cloudera.org/r/418/#comment3116>

    Shouldn't this be "greater than" instead of "less than"? Otherwise we are looking for
errors only in elements changed in the last timelag milliseconds, which is exactly the opposite
of what we want.


- Alexander


On 2010-07-28 16:22:47, Todd Lipcon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/418/
> -----------------------------------------------------------
> 
> (Updated 2010-07-28 16:22:47)
> 
> 
> Review request for hbase, stack, dhruba borthakur, and Kannan Muthukkaruppan.
> 
> 
> Summary
> -------
> 
> Bunch of changes to the HBaseFsck tool to detect a wider variety of issues and to make
it easier to add "fix" support for these problems in the future.
> 
> 
> This addresses bug HBASE-2887.
>     http://issues.apache.org/jira/browse/HBASE-2887
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java 19cdec1 
>   src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 5f8b909 
>   src/test/java/org/apache/hadoop/hbase/client/TestHBaseFsck.java PRE-CREATION 
> 
> Diff: http://review.cloudera.org/r/418/diff
> 
> 
> Testing
> -------
> 
> Tested an earlier variation of this patch against my cluster in various screwed up states.
This patch adds a basic unit test but it could be improved to use a mock cluster and test
more variations.
> 
> 
> Thanks,
> 
> Todd
> 
>


Mime
View raw message