hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray" <jg...@apache.org>
Subject Re: Review Request: Fault in logic in BinaryPrefixComparator leads to ArrayIndexOutOfBoundsException
Date Wed, 18 Aug 2010 22:26:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/686/#review949
-----------------------------------------------------------

Ship it!


Looks good to me.

- Jonathan


On 2010-08-18 14:46:42, Pranav Khaitan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/686/
> -----------------------------------------------------------
> 
> (Updated 2010-08-18 14:46:42)
> 
> 
> Review request for hbase and Jonathan Gray.
> 
> 
> Summary
> -------
> 
> Following statement makes an incorrect assumption that value.length >= this.value.length.
> 
> return Bytes.compareTo(this.value, 0, this.value.length, value, 0,
> this.value.length);
> 
> 
> (Also, removed a couple of unused imports)
> 
> 
> This addresses bug HBASE-2928.
>     http://issues.apache.org/jira/browse/HBASE-2928
> 
> 
> Diffs
> -----
> 
>   trunk/src/main/java/org/apache/hadoop/hbase/filter/BinaryPrefixComparator.java 986945

>   trunk/src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java 986945 
> 
> Diff: http://review.cloudera.org/r/686/diff
> 
> 
> Testing
> -------
> 
> All tests based on PrefixFilter run successfully.
> 
> 
> Thanks,
> 
> Pranav
> 
>


Mime
View raw message