Return-Path: 
 <dev-return-20058-apmail-hbase-dev-archive=hbase.apache.org@hbase.apache.org>
Delivered-To: apmail-hbase-dev-archive@www.apache.org
Received: (qmail 37676 invoked from network); 25 Jul 2010 20:32:23 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 25 Jul 2010 20:32:23 -0000
Received: (qmail 88641 invoked by uid 500); 25 Jul 2010 20:32:22 -0000
Delivered-To: apmail-hbase-dev-archive@hbase.apache.org
Received: (qmail 88581 invoked by uid 500); 25 Jul 2010 20:32:21 -0000
Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@hbase.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@hbase.apache.org>
List-Post: <mailto:dev@hbase.apache.org>
List-Id: <dev.hbase.apache.org>
Reply-To: dev@hbase.apache.org
Delivered-To: mailing list dev@hbase.apache.org
Received: (qmail 88573 invoked by uid 99); 25 Jul 2010 20:32:21 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 25 Jul 2010 20:32:21 +0000
X-ASF-Spam-Status: No, hits=2.2 required=10.0
	tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of yuzhihong@gmail.com
 designates 209.85.160.169 as permitted sender)
Received: from [209.85.160.169] (HELO mail-gy0-f169.google.com)
 (209.85.160.169)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 25 Jul 2010 20:32:16 +0000
Received: by gyb11 with SMTP id 11so871166gyb.14
        for <dev@hbase.apache.org>; Sun, 25 Jul 2010 13:31:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:received:in-reply-to
         :references:date:message-id:subject:from:to:content-type;
        bh=YW9RzDgAu+fYkrK1QZN74TM5mdqFie7x64Z1YoPuOmI=;
        b=i/sptLqIYrRvmwJpYWWhdnR+m/Ye3z3KYmnF/yXSre7gObWb6LwWk3ywYdJH1MEZGh
         o3kLtoFoh10IEnZVtupshlSq/8E24HYiihllysRtHJuMzOVIqf0nXZfm6Noft5h+Kj86
         ohzrGF975QC1IVN+krnKWdu7kq1k4/b1mJoc4=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=VkZRBZ5/VuC/LegjSOEs6nbJhywYG6SZODhRIOOsmwLN864OpoKnXFCmIY+zGYtl/a
         q2xKiieIOlQoGBG8iRm+SPBM1eik/YmGSP64xAnkZBZZSpBho6CaQZnIH4qT7oAbksgv
         +yC9g3zlT0/+YNHEr8K/ZnPT9eRLyjeyAdqb0=
MIME-Version: 1.0
Received: by 10.100.164.6 with SMTP id m6mr6749293ane.54.1280089915508; Sun,
	25 Jul 2010 13:31:55 -0700 (PDT)
Received: by 10.101.4.24 with HTTP; Sun, 25 Jul 2010 13:31:55 -0700 (PDT)
In-Reply-To: <20100707234839.13206.80779@ip-10-250-127-239.ec2.internal>
References: <20100707234839.13206.80779@ip-10-250-127-239.ec2.internal>
Date: Sun, 25 Jul 2010 13:31:55 -0700
Message-ID: <AANLkTi=qGQ3qatLPguY0srFqVyzO9JM4Ab69NquEU6fz@mail.gmail.com>
Subject: Re: Review Request: First cut at a working load balancer
From: Ted Yu <yuzhihong@gmail.com>
To: dev@hbase.apache.org
Content-Type: multipart/alternative; boundary=0016e64355f2b1d6ec048c3c28fe

--0016e64355f2b1d6ec048c3c28fe
Content-Type: text/plain; charset=ISO-8859-1

Jonathan:
Can you elaborate on how the following information (input to balanceCluster)
is gathered ?

Map<HServerInfo,List<HRegionInfo>> serverInfo

Considering the implication from HBASE-2473, some (pre-created) regions may
stay empty for some time. Would those regions be included in the above Map ?

Thanks

On Wed, Jul 7, 2010 at 4:48 PM, Jonathan Gray <jgray@apache.org> wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/282/
> -----------------------------------------------------------
>
> Review request for hbase.
>
>
> Summary
> -------
>
> Just putting this up to show people.  It's not done but the
> balanceCluster() method "works" and has a bunch of test cases.
>
>
> This addresses bug HBASE-2697.
>    http://issues.apache.org/jira/browse/HBASE-2697
>
>
> Diffs
> -----
>
>  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/HServerInfo.java
> 961064
>  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java
> PRE-CREATION
>  branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/master/TestLoadBalancer.java
> PRE-CREATION
>
> Diff: http://review.hbase.org/r/282/diff
>
>
> Testing
> -------
>
> Added TestLoadBalancer.testLoadBalancer_balanceCluster().  If you have any
> good edge cases let me know!
>
>
> Thanks,
>
> Jonathan
>
>

--0016e64355f2b1d6ec048c3c28fe--