Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 14460 invoked from network); 28 Jul 2010 23:23:16 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 28 Jul 2010 23:23:16 -0000 Received: (qmail 17462 invoked by uid 500); 28 Jul 2010 23:23:15 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 17402 invoked by uid 500); 28 Jul 2010 23:23:15 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 17383 invoked by uid 99); 28 Jul 2010 23:23:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jul 2010 23:23:14 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [184.73.217.71] (HELO ip-10-202-7-187.ec2.internal) (184.73.217.71) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jul 2010 23:23:08 +0000 Received: from ip-10-202-7-187.ec2.internal (localhost [127.0.0.1]) by ip-10-202-7-187.ec2.internal (Postfix) with ESMTP id 9ACA78A1C6; Wed, 28 Jul 2010 23:22:47 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Review Request: Improvements to HBaseFsck tool From: "Todd Lipcon" To: "Kannan Muthukkaruppan" , "dhruba borthakur" , stack@duboce.net Date: Wed, 28 Jul 2010 23:22:47 -0000 Message-ID: <20100728232247.12819.37646@ip-10-202-7-187.ec2.internal> Cc: "Todd Lipcon" , dev@hbase.apache.org, jiraposter@review.hbase.org X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/418/ ----------------------------------------------------------- Review request for hbase, stack, dhruba borthakur, and Kannan Muthukkaruppa= n. Summary ------- Bunch of changes to the HBaseFsck tool to detect a wider variety of issues = and to make it easier to add "fix" support for these problems in the future. This addresses bug HBASE-2887. http://issues.apache.org/jira/browse/HBASE-2887 Diffs ----- src/main/java/org/apache/hadoop/hbase/client/HBaseFsck.java 19cdec1 = src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 5f8b909 = src/test/java/org/apache/hadoop/hbase/client/TestHBaseFsck.java PRE-CREAT= ION = Diff: http://review.cloudera.org/r/418/diff Testing ------- Tested an earlier variation of this patch against my cluster in various scr= ewed up states. This patch adds a basic unit test but it could be improved = to use a mock cluster and test more variations. Thanks, Todd