Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: Review Request: ZKAssign.  New zookeeper assignment methods.
From: "Jonathan Gray" <jgray@apache.org>
To: "Karthik Ranganathan" <karthik.ranga@gmail.com>,
	"Kannan Muthukkaruppan" <kannan@facebook.com>,
	"Jean-Daniel Cryans" <jdcryans@apache.org>, stack@duboce.net
Date: Fri, 23 Jul 2010 23:29:43 -0000
Message-ID: <20100723232943.14395.3522@ip-10-250-127-239.ec2.internal>
Cc: jiraposter@review.hbase.org, "Jonathan Gray" <jgray@apache.org>,
	dev@hbase.apache.org
In-Reply-To: <20100723232815.14408.25949@ip-10-250-127-239.ec2.internal>
References: <20100723232815.14408.25949@ip-10-250-127-239.ec2.internal>


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/382/
-----------------------------------------------------------

(Updated 2010-07-23 16:29:43.251978)


Review request for hbase, stack, Jean-Daniel Cryans, Karthik Ranganathan, a=
nd Kannan Muthukkaruppan.


Changes
-------

Should I put above description into the class comment javadoc or is it too =
much for there?


Summary (updated)
-------

This method implements all the zookeeper methods needed for this last part =
of the doc posted in HBASE-2692 (definition of valid creation/transitions f=
or unassigned znodes):


  MASTER
  =

  1. Master creates an unassigned node as OFFLINE.
  =

     - Cluster startup and table enabling. =

  =

  2. Master forces an existing unassigned node to OFFLINE.
  =

     - RegionServer failure.
     =

     - Allows transitions from all states to OFFLINE.
  =

  3. Master deletes an unassigned node that was in a OPENED state.
  =

     - Normal region transitions.  Besides cluster startup, no other deleti=
ons
       of unassigned nodes is allowed.
       =

  4. Master deletes all unassigned nodes regardless of state.
  =

     - Cluster startup before any assignment happens.
  =

  REGIONSERVER
  =

  1. RegionServer creates an unassigned node as CLOSING.
  =

     - All region closes will do this in response to a CLOSE RPC from Maste=
r.
     =

     - A node can never be transitioned to CLOSING, only created.
  =

  2. RegionServer transitions an unassigned node from CLOSING to CLOSED.
  =

     - Normal region closes.  CAS operation.
  =

  3. RegionServer transitions an unassigned node from OFFLINE to OPENING.
  =

     - All region opens will do this in response to an OPEN RPC from the Ma=
ster.
     =

     - Normal region opens.  CAS operation.
     =

  4. RegionServer transitions an unassigned node from OPENING to OPENED.
  =

     - Normal region opens.  CAS operation.


Should I put above into the class comment javadoc or is it too much for the=
re?


This addresses bug HBASE-2697.
    http://issues.apache.org/jira/browse/HBASE-2697


Diffs
-----

  branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookee=
per/ZKAssign.java PRE-CREATION =


Diff: http://review.hbase.org/r/382/diff


Testing
-------

Unit test to come.  Just putting up since there have been some recent issue=
s with multiple transitions and stuff, wanted to show what the new stuff lo=
oks like.


Thanks,

Jonathan