Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 70446 invoked from network); 23 Jul 2010 22:52:17 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 23 Jul 2010 22:52:17 -0000 Received: (qmail 23930 invoked by uid 500); 23 Jul 2010 22:52:17 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 23877 invoked by uid 500); 23 Jul 2010 22:52:16 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Delivered-To: moderator for dev@hbase.apache.org Received: (qmail 96461 invoked by uid 99); 23 Jul 2010 22:29:20 -0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-2866 Region permanently offlined From: "Jean-Daniel Cryans" To: "Kannan Muthukkaruppan" , stack@duboce.net Date: Fri, 23 Jul 2010 22:28:54 -0000 Message-ID: <20100723222854.14380.98634@ip-10-250-127-239.ec2.internal> Cc: "Karthik Ranganathan" , dev@hbase.apache.org, jiraposter@review.hbase.org, "Jean-Daniel Cryans" In-Reply-To: <20100723220816.14408.44347@ip-10-250-127-239.ec2.internal> References: <20100723220816.14408.44347@ip-10-250-127-239.ec2.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/380/#review473 ----------------------------------------------------------- Ship it! +1 LGTM and TestAdmin passes on my machine without flinching - Jean-Daniel On 2010-07-23 15:08:16, Karthik Ranganathan wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/380/ > ----------------------------------------------------------- > = > (Updated 2010-07-23 15:08:16) > = > = > Review request for hbase, stack and Kannan Muthukkaruppan. > = > = > Summary > ------- > = > Region permanently offlined - if the ZNode is already in the target state= , do not update it again. > = > = > This addresses bug HBASE-2866. > http://issues.apache.org/jira/browse/HBASE-2866 > = > = > Diffs > ----- > = > trunk/src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.= java 967128 = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.= java 967128 = > = > Diff: http://review.hbase.org/r/380/diff > = > = > Testing > ------- > = > Ran unit tests, went through fine (except TestRowAtomicity, which is know= n to be failing). > = > = > Thanks, > = > Karthik > = >