Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 23649 invoked from network); 23 Jul 2010 20:41:36 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 23 Jul 2010 20:41:36 -0000 Received: (qmail 72444 invoked by uid 500); 23 Jul 2010 20:41:36 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 72386 invoked by uid 500); 23 Jul 2010 20:41:36 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 72378 invoked by uid 99); 23 Jul 2010 20:41:35 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jul 2010 20:41:35 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [75.101.130.251] (HELO ip-10-250-127-239.ec2.internal) (75.101.130.251) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jul 2010 20:41:30 +0000 Received: from ip-10-250-127-239.ec2.internal (localhost.localdomain [127.0.0.1]) by ip-10-250-127-239.ec2.internal (Postfix) with ESMTP id 3086A1056C; Fri, 23 Jul 2010 20:41:09 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: distributed log splitting now with better testing and configurable splitting From: "Jonathan Gray" To: "Alex Newman" , "Jonathan Gray" , jiraposter@review.hbase.org, dev@hbase.apache.org Date: Fri, 23 Jul 2010 20:41:09 -0000 Message-ID: <20100723204109.14395.62570@ip-10-250-127-239.ec2.internal> In-Reply-To: <20100723002512.14408.1356@ip-10-250-127-239.ec2.internal> References: <20100723002512.14408.1356@ip-10-250-127-239.ec2.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/370/#review467 ----------------------------------------------------------- Hey Alex, this is looking good. The master rewrite branch has a refactorin= g of ZooKeeperWrapper and general ZK usage inside HBase that conflicts with= this pretty significantly. Do you think you could pull the new methods and classes nested in ZooKeeper= Wrapper into a separate class of static methods? If you need the instantia= ted instance of ZKW, pass it in as the first argument to the static methods= ? That will make my life WAY easier when I have to merge the branch back i= nto trunk. Also gives an opportunity to have a class comment in the new class explaini= ng the overall usage of zk. Stuff like the names of the nodes can be left in the instantiated ZKW class= since it makes sense to pull those in from the confs on instantiation. Cool? Let me know if you want an example. - Jonathan On 2010-07-22 17:25:12, Alex Newman wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/370/ > ----------------------------------------------------------- > = > (Updated 2010-07-22 17:25:12) > = > = > Review request for hbase. > = > = > Summary > ------- > = > This build on the previous work. It does some smarter stuff with testing = and now splitting is configurable. > = > = > This addresses bug hbase-1364. > http://issues.apache.org/jira/browse/hbase-1364 > = > = > Diffs > ----- > = > src/main/java/org/apache/hadoop/hbase/HConstants.java c77ebf5 = > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java f= 251d54 = > src/main/java/org/apache/hadoop/hbase/regionserver/LogSplitter.java PRE= -CREATION = > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 5688c0= 3 = > src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java 8= 225178 = > src/main/resources/hbase-default.xml e3a9669 = > src/test/java/org/apache/hadoop/hbase/regionserver/wal/BaseTestHLogSpli= t.java PRE-CREATION = > src/test/java/org/apache/hadoop/hbase/regionserver/wal/DistributedTestH= Log.java PRE-CREATION = > src/test/java/org/apache/hadoop/hbase/regionserver/wal/DistributedTestH= LogSplit.java PRE-CREATION = > src/test/java/org/apache/hadoop/hbase/regionserver/wal/DistributedTestH= LogSplitSkipErrors.java PRE-CREATION = > src/test/java/org/apache/hadoop/hbase/regionserver/wal/DistributedTestL= ogRolling.java PRE-CREATION = > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java ad= 8f9e5 = > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.ja= va 908633e = > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplitSki= pErrors.java PRE-CREATION = > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogActionsLi= stener.java 776d78c = > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.j= ava 9eae4b4 = > src/test/resources/hbase-site.xml 3c0601a = > = > Diff: http://review.hbase.org/r/370/diff > = > = > Testing > ------- > = > ran on our private hudson > = > = > Thanks, > = > Alex > = >