Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 74649 invoked from network); 23 Jul 2010 06:12:02 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 23 Jul 2010 06:12:02 -0000 Received: (qmail 2331 invoked by uid 500); 23 Jul 2010 06:12:02 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 2043 invoked by uid 500); 23 Jul 2010 06:11:59 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 2014 invoked by uid 99); 23 Jul 2010 06:11:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jul 2010 06:11:58 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: 75.101.130.251 is neither permitted nor denied by domain of stack@duboce.net) Received: from [75.101.130.251] (HELO ip-10-250-127-239.ec2.internal) (75.101.130.251) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jul 2010 06:11:53 +0000 Received: from ip-10-250-127-239.ec2.internal (localhost.localdomain [127.0.0.1]) by ip-10-250-127-239.ec2.internal (Postfix) with ESMTP id 514E71056C; Fri, 23 Jul 2010 06:11:32 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: Query matcher will be confused if intra-row scanning From: stack@duboce.net To: "Andrew Purtell" , jiraposter@review.hbase.org, dev@hbase.apache.org, stack@duboce.net Date: Fri, 23 Jul 2010 06:11:32 -0000 Message-ID: <20100723061132.14408.38977@ip-10-250-127-239.ec2.internal> In-Reply-To: <20100723052814.14408.52799@ip-10-250-127-239.ec2.internal> References: <20100723052814.14408.52799@ip-10-250-127-239.ec2.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/376/#review463 ----------------------------------------------------------- Ship it! +1 on commit. Suggestion on how to make some minor savings. Go ahead and = commit with if it makes sense to you (or do w/o the suggestion). src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java Consider using method Ryan added today: = public boolean matchingRows(final KeyValue left, final byte [] righ= t) { = Then you could do if (!KeyValue.matchingRows(matcher.row, peeked) = .. and only do a peeked.getRow when you know you've changed rows.. = Might same a bit of byte array making. - stack On 2010-07-22 22:28:14, Andrew Purtell wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/376/ > ----------------------------------------------------------- > = > (Updated 2010-07-22 22:28:14) > = > = > Review request for hbase. > = > = > Summary > ------- > = > Query matcher will be confused if intra-row scanning. Avoid calling setRo= w() if the row has not changed. This requires a string comparison per next(= ). > = > = > This addresses bug HBASE-1537. > http://issues.apache.org/jira/browse/HBASE-1537 > = > = > Diffs > ----- > = > src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java dc= 2e234 = > = > Diff: http://review.hbase.org/r/376/diff > = > = > Testing > ------- > = > = > Thanks, > = > Andrew > = >