Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 99760 invoked from network); 13 Jul 2010 18:12:18 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 13 Jul 2010 18:12:18 -0000 Received: (qmail 67415 invoked by uid 500); 13 Jul 2010 18:12:18 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 67366 invoked by uid 500); 13 Jul 2010 18:12:17 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 67358 invoked by uid 99); 13 Jul 2010 18:12:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jul 2010 18:12:17 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,MIME_QP_LONG_LINE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 75.101.130.251 is neither permitted nor denied by domain of stack@duboce.net) Received: from [75.101.130.251] (HELO ip-10-250-127-239.ec2.internal) (75.101.130.251) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jul 2010 18:12:08 +0000 Received: from ip-10-250-127-239.ec2.internal (localhost.localdomain [127.0.0.1]) by ip-10-250-127-239.ec2.internal (Postfix) with ESMTP id E44BF1056C; Tue, 13 Jul 2010 18:11:17 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-2740 NPE in ReadWriteConsistencyControl From: stack@duboce.net To: stack@duboce.net Date: Tue, 13 Jul 2010 18:11:17 -0000 Message-ID: <20100713181117.21384.70679@ip-10-250-127-239.ec2.internal> Cc: "Ryan Rawson" , jiraposter@review.hbase.org, dev@hbase.apache.org In-Reply-To: <20100617045925.22015.51501@ip-10-250-218-255.ec2.internal> References: <20100617045925.22015.51501@ip-10-250-218-255.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org > On 2010-06-16 21:59:25, stack wrote: > > +1 on commit as long as commit includes some version of explaination ju= st given here on review board. Does it have to go into trunk and branch? This patch is still not committed (along w/ accomodation of my criticisms m= ade here in review.hbase.org). - stack ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/191/#review251 ----------------------------------------------------------- On 2010-06-16 17:22:31, Ryan Rawson wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/191/ > ----------------------------------------------------------- > = > (Updated 2010-06-16 17:22:31) > = > = > Review request for hbase and stack. > = > = > Summary > ------- > = > HBASE-2740 NPE in ReadWriteConsistencyControl > = > = > Diffs > ----- > = > src/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java 6d4546f = > src/test/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java 76a= b7b5 = > = > Diff: http://review.hbase.org/r/191/diff > = > = > Testing > ------- > = > = > Thanks, > = > Ryan > = >