Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 60093 invoked from network); 13 Jul 2010 03:40:16 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 13 Jul 2010 03:40:16 -0000 Received: (qmail 1280 invoked by uid 500); 13 Jul 2010 03:40:16 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 879 invoked by uid 500); 13 Jul 2010 03:40:13 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 854 invoked by uid 99); 13 Jul 2010 03:40:12 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jul 2010 03:40:12 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [75.101.130.251] (HELO ip-10-250-127-239.ec2.internal) (75.101.130.251) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jul 2010 03:40:05 +0000 Received: from ip-10-250-127-239.ec2.internal (localhost.localdomain [127.0.0.1]) by ip-10-250-127-239.ec2.internal (Postfix) with ESMTP id 943A81056C; Tue, 13 Jul 2010 03:39:44 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-2832: Priorities and multi-threading for MemStore flushing From: "Jonathan Gray" To: "Karthik Ranganathan" , "Kannan Muthukkaruppan" , stack@duboce.net Date: Tue, 13 Jul 2010 03:39:44 -0000 Message-ID: <20100713033944.6966.23699@ip-10-250-127-239.ec2.internal> Cc: "Jonathan Gray" , jiraposter@review.hbase.org, dev@hbase.apache.org In-Reply-To: <20100713020350.21384.71684@ip-10-250-127-239.ec2.internal> References: <20100713020350.21384.71684@ip-10-250-127-239.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/301/ ----------------------------------------------------------- (Updated 2010-07-12 20:39:44.545617) Review request for hbase, stack, Karthik Ranganathan, and Kannan Muthukkaru= ppan. Summary ------- Adds support for priorities and concurrency to regionserver flushing. - Adds support for RS-side events/handlers/executors - Adds support for prioritized HBaseEventHandlers - Flushing now happens through FlushHandler, a new HBaseEventHandler. Ther= e is an RS_FLUSHER executor pool that defaults to two threads right now but= is also checking a conf value. There is a good bit of documentation in Fl= ushHandler. - Adds unit test TestFlushHandler. There is a nicer way to detect when flu= shes finish now for other tests. - Handling of FS errors is pushed into FlushHandler now. The changes happe= ning with the master rewrite introduce a ServerStatus interface (probably a= RegionStatus for rs side) that will contain the necessary methods rather t= han using HRegionServer directly as is required for now. - Something weird not passing in tests with multiple masters and regionserv= ers, still working that out. This addresses bug HBASE-2832. http://issues.apache.org/jira/browse/HBASE-2832 Diffs ----- trunk/src/main/java/org/apache/hadoop/hbase/executor/HBaseEventHandler.ja= va 963507 = trunk/src/main/java/org/apache/hadoop/hbase/executor/HBaseExecutorService= .java 963507 = trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 963507 = trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThre= ad.java 963507 = trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.ja= va 963507 = trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.= java 963507 = trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/FlushHan= dler.java PRE-CREATION = trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestFlushHandler= .java PRE-CREATION = Diff: http://review.hbase.org/r/301/diff Testing ------- Adds TestFlushHandler which passes. Working on getting unit tests passing = now, something related to the ExecutorService. Thanks, Jonathan