Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 54535 invoked from network); 13 Jul 2010 03:28:16 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 13 Jul 2010 03:28:16 -0000 Received: (qmail 90111 invoked by uid 500); 13 Jul 2010 03:28:16 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 89842 invoked by uid 500); 13 Jul 2010 03:28:14 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Delivered-To: moderator for dev@hbase.apache.org Received: (qmail 75401 invoked by uid 99); 13 Jul 2010 02:49:13 -0000 X-ASF-Spam-Status: No, hits=2.1 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_SOFTFAIL X-Spam-Check-By: apache.org Received-SPF: softfail (nike.apache.org: transitioning domain of kjirapinyo@attensity.com does not designate 75.101.130.251 as permitted sender) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-2794 Multi Column Bloom Filter Check From: "Kris Jirapinyo" To: "Kannan Muthukkaruppan" , "Nicolas" , "Kris Jirapinyo" , jiraposter@review.hbase.org, dev@hbase.apache.org Date: Tue, 13 Jul 2010 02:48:43 -0000 Message-ID: <20100713024843.21402.86540@ip-10-250-127-239.ec2.internal> In-Reply-To: <20100712055442.21384.7830@ip-10-250-127-239.ec2.internal> References: <20100712055442.21384.7830@ip-10-250-127-239.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/296/ ----------------------------------------------------------- (Updated 2010-07-12 19:48:43.373418) Review request for hbase. Changes ------- Implemented Kannan's suggestion, thereby removing keyList. Summary ------- HBASE-2794 Enable bloom filter checks for multiple columns in same column f= amily This addresses bug HBASE-2794. http://issues.apache.org/jira/browse/HBASE-2794 Diffs (updated) ----- /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java = 962748 = /trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.j= ava 962748 = Diff: http://review.hbase.org/r/296/diff Testing ------- Ran and passed org.apache.hadoop.hbase.regionserver.TestStoreFile multiple = times. Ran and passed all tests when building. Thanks, Kris