Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 19254 invoked from network); 12 Jul 2010 20:26:57 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 12 Jul 2010 20:26:57 -0000 Received: (qmail 40572 invoked by uid 500); 12 Jul 2010 20:26:57 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 40505 invoked by uid 500); 12 Jul 2010 20:26:56 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Delivered-To: moderator for dev@hbase.apache.org Received: (qmail 36661 invoked by uid 99); 12 Jul 2010 20:22:19 -0000 X-ASF-Spam-Status: No, hits=2.1 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_SOFTFAIL X-Spam-Check-By: apache.org Received-SPF: softfail (nike.apache.org: transitioning domain of kjirapinyo@attensity.com does not designate 75.101.130.251 as permitted sender) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-2794 Multi Column Bloom Filter Check From: "Kris Jirapinyo" To: "Kannan Muthukkaruppan" , "Kris Jirapinyo" , jiraposter@review.hbase.org, dev@hbase.apache.org Date: Mon, 12 Jul 2010 20:21:50 -0000 Message-ID: <20100712202150.21402.60515@ip-10-250-127-239.ec2.internal> In-Reply-To: <20100712201432.21402.28276@ip-10-250-127-239.ec2.internal> References: <20100712201432.21402.28276@ip-10-250-127-239.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org > On 2010-07-12 13:14:32, Kannan Muthukkaruppan wrote: > > /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.jav= a, line 880 > > > > > > can't this loop be over "columns" itself? And then inside the loop,= you prepare one key at a time use Bytes.add(row, col). That way, you can a= void the keyList data structure completely. Another good idea :) Will also get rid of the warning that keyList could po= ssibly be null. - Kris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/296/#review361 ----------------------------------------------------------- On 2010-07-11 22:54:42, Kris Jirapinyo wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/296/ > ----------------------------------------------------------- > = > (Updated 2010-07-11 22:54:42) > = > = > Review request for hbase. > = > = > Summary > ------- > = > HBASE-2794 Enable bloom filter checks for multiple columns in same column= family > = > = > This addresses bug HBASE-2794. > http://issues.apache.org/jira/browse/HBASE-2794 > = > = > Diffs > ----- > = > /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.jav= a 962748 = > /trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile= .java 962748 = > = > Diff: http://review.hbase.org/r/296/diff > = > = > Testing > ------- > = > Ran and passed org.apache.hadoop.hbase.regionserver.TestStoreFile multipl= e times. Ran and passed all tests when building. > = > = > Thanks, > = > Kris > = >