hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chongxin Li" <lichong...@zju.edu.cn>
Subject Re: Review Request: HBASE-2792: Create a better way to chain log cleaners
Date Sat, 24 Jul 2010 12:10:08 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-07-24 05:10:08.798554)

Review request for hbase.


Since currently there are only two log cleaners (TimeToLiveLogCleaner and ReplicationLogCleaner)
in the chain, there would be 3 scenarios, that is log file doesn't pass the first log cleaner;
log file passes the first log cleaner but is rejected by the second; log file passes both
log cleaners and is then deleted. I think these 3 cases are all covered by the unit test.
I've added some comments to the unit test to explain these 3 cases.


HBASE-2792: Create a better way to chain log cleaners

This addresses bug HBASE-2792.

Diffs (updated)

  src/main/java/org/apache/hadoop/hbase/master/LogCleanerDelegate.java 3ca3611 
  src/main/java/org/apache/hadoop/hbase/master/LogsCleaner.java 37b2c3c 
  src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 9fb1cce 
  src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java eb859aa

  src/main/resources/hbase-default.xml e3a9669 
  src/test/java/org/apache/hadoop/hbase/master/TestLogsCleaner.java a92e0da 

Diff: http://review.hbase.org/r/372/diff


Unit test TestOldLogsCleaner passed.



View raw message