hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: HBASE-2863 -- HBASE-2553 removed an important edge case
Date Thu, 22 Jul 2010 13:57:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/354/#review450
-----------------------------------------------------------


At least missing license needs fixing.  There's at least one question in the below too.  Good
stuff.


src/main/java/org/apache/hadoop/hbase/KeyValue.java
<http://review.hbase.org/r/354/#comment1878>

    Nice.



src/main/java/org/apache/hadoop/hbase/KeyValue.java
<http://review.hbase.org/r/354/#comment1879>

    Nice here too



src/main/java/org/apache/hadoop/hbase/KeyValue.java
<http://review.hbase.org/r/354/#comment1880>

    Good stuff.



src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
<http://review.hbase.org/r/354/#comment1881>

    Could this first kv on the row in memstore have a ts in advance of 'now'?  I suppose it
can't -- least it shouldn't be possible, right?
    
    If  thousands of updates a second, could this be a prob?  This logic?



src/main/java/org/apache/hadoop/hbase/util/ManualEnvironmentEdge.java
<http://review.hbase.org/r/354/#comment1882>

    Missing license



src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
<http://review.hbase.org/r/354/#comment1883>

    Nice test


- stack


On 2010-07-22 01:07:55, Ryan Rawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/354/
> -----------------------------------------------------------
> 
> (Updated 2010-07-22 01:07:55)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> There are tricky edge cases that were removed by HBASE-2553 (oopsy!)... flaky tests have
been illustrating them. This patch fixes those flaky tests to be not flaky (using the EnvironmentEdgeManager
thing) and also fixes them, and introduces tests that cover the particular use cases slightly
better as well. Oh yes and and fixes the actual bug.
> 
> Without these fixes we would end up with KVs with different values with the same Timestamp
which causes problems.  This can happen when we get more than 1 increment/millisecond and
especially during a snapshot.
> 
> 
> This addresses bug HBASE-2863.
>     http://issues.apache.org/jira/browse/HBASE-2863
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/KeyValue.java e32d683 
>   src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java 44fa0c3 
>   src/main/java/org/apache/hadoop/hbase/regionserver/Store.java c1ff9f2 
>   src/main/java/org/apache/hadoop/hbase/util/ManualEnvironmentEdge.java PRE-CREATION

>   src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 4ead02d 
>   src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java a32eed6 
> 
> Diff: http://review.hbase.org/r/354/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryan
> 
>


Mime
View raw message