Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 30761 invoked from network); 11 Jun 2010 07:50:37 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 11 Jun 2010 07:50:37 -0000 Received: (qmail 62130 invoked by uid 500); 11 Jun 2010 07:50:36 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 61540 invoked by uid 500); 11 Jun 2010 07:50:34 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 61531 invoked by uid 99); 11 Jun 2010 07:50:33 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Jun 2010 07:50:33 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [75.101.130.251] (HELO ip-10-250-218-255.ec2.internal) (75.101.130.251) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Jun 2010 07:50:26 +0000 Received: from ip-10-250-218-255.ec2.internal (localhost.localdomain [127.0.0.1]) by ip-10-250-218-255.ec2.internal (Postfix) with ESMTP id 5BC5FEE26; Fri, 11 Jun 2010 07:50:05 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Review Request: Batch writes should sync to HLog in batches From: "Todd Lipcon" To: "Kannan Muthukkaruppan" , "Ryan Rawson" Date: Fri, 11 Jun 2010 07:50:05 -0000 Message-ID: <20100611075005.27729.54039@ip-10-250-218-255.ec2.internal> Cc: "Todd Lipcon" , jiraposter@review.hbase.org, dev@hbase.apache.org X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/167/ ----------------------------------------------------------- Review request for hbase, Kannan Muthukkaruppan and Ryan Rawson. Summary ------- I implemented the "mini batching" idea we talked about on the JIRA. This currently breaks some of the error handling, so I dont intend to commi= t as is, but everyone is busy so wanted to put a review up now while I tidy= up the rest. This addresses bug HBASE-2353. http://issues.apache.org/jira/browse/HBASE-2353 Diffs ----- src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6b6d098 = src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java a1b= aff4 = src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 034690e = Diff: http://review.hbase.org/r/167/diff Testing ------- Some PEs on a real sync-enabled cluster, seems faster but haven't done scie= ntific benchmarking. Thanks, Todd