Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 97722 invoked from network); 10 Jun 2010 15:35:53 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 10 Jun 2010 15:35:53 -0000 Received: (qmail 71037 invoked by uid 500); 10 Jun 2010 15:35:53 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 70995 invoked by uid 500); 10 Jun 2010 15:35:52 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 70987 invoked by uid 99); 10 Jun 2010 15:35:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Jun 2010 15:35:52 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [75.101.130.251] (HELO ip-10-250-218-255.ec2.internal) (75.101.130.251) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Jun 2010 15:35:46 +0000 Received: from ip-10-250-218-255.ec2.internal (localhost.localdomain [127.0.0.1]) by ip-10-250-218-255.ec2.internal (Postfix) with ESMTP id 9111FEDC2; Thu, 10 Jun 2010 15:35:25 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-2618 Don't inherit from HConstants. From: "Jonathan Gray" To: "Jonathan Gray" , jiraposter@review.hbase.org, dev@hbase.apache.org, "Benoit Sigoure" Date: Thu, 10 Jun 2010 15:35:25 -0000 Message-ID: <20100610153525.27731.4866@ip-10-250-218-255.ec2.internal> In-Reply-To: <20100610062932.27731.56785@ip-10-250-218-255.ec2.internal> References: <20100610062932.27731.56785@ip-10-250-218-255.ec2.internal> > On 2010-06-09 23:29:32, Benoit Sigoure wrote: > > Can we apply this patch now? Yes, can you just post your final patch into the JIRA and I will commit? L= ast I checked there were no patches in jira. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/132/#review173 ----------------------------------------------------------- On 2010-06-08 10:05:23, Benoit Sigoure wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/132/ > ----------------------------------------------------------- > = > (Updated 2010-06-08 10:05:23) > = > = > Review request for hbase. > = > = > Summary > ------- > = > HBASE-2618 Don't inherit from HConstants. > = > Bonus: minor aesthetic / coding style clean ups and minor code changes. > = > = > This addresses bug HBASE-2618. > = > = > Diffs > ----- > = > trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java 952565 = > trunk/src/main/java/org/apache/hadoop/hbase/HMerge.java 952565 = > trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 9525= 65 = > trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.j= ava 952565 = > trunk/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 952= 565 = > trunk/src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java 952= 565 = > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 952565 = > trunk/src/main/java/org/apache/hadoop/hbase/master/RegionManager.java 9= 52565 = > trunk/src/main/java/org/apache/hadoop/hbase/master/RegionServerOperatio= n.java 952565 = > trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 9= 52565 = > trunk/src/main/java/org/apache/hadoop/hbase/master/TableOperation.java = 952565 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitTh= read.java 952565 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 9= 52565 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.= java 952565 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 952= 565 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java= 952565 = > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java = 952565 = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java = 952565 = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java= 952565 = > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.= java 952565 = > trunk/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 95256= 5 = > trunk/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java = 952565 = > trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitCo= lumnTracker.java 952565 = > trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosest= AtOrBefore.java 952565 = > trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetDeleteT= racker.java 952565 = > trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeyValueHe= ap.java 952565 = > trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestQueryMatch= er.java 952565 = > trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanDelete= Tracker.java 952565 = > trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestWildcardCo= lumnTracker.java 952565 = > trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.j= ava 952565 = > = > Diff: http://review.hbase.org/r/132/diff > = > = > Testing > ------- > = > Code compiles. > Tests are acting up on my machine right now (many of them fail with a wei= rd message [1] and Todd says he's been seeing similar failures for some tim= e already, so I guess I'll try to run them again next week when the New Moo= n arrives). > = > = > [1] A number of tests fail with: > org.apache.hadoop.hbase.client.NoServerForRegionException: Timed out tryi= ng to locate root region because: Failed setting up proxy to /192.168.0.7:6= 3773 after attempts=3D1 > at org.apache.hadoop.hbase.client.HConnectionManager$TableServers= .locateRootRegion(HConnectionManager.java:1031) > Where, of course, 192.168.0.7 is my IP address. > Some of the tests that are acting up: > org.apache.hadoop.hbase.TestZooKeeper, org.apache.hadoop.hbase.regionserv= er.wal.TestLogRolling, org.apache.hadoop.hbase.rest.TestScannersWithFilters= , org.apache.hadoop.hbase.master.TestMasterWrongRS, org.apache.hadoop.hbase= .thrift.TestThriftServer, org.apache.hadoop.hbase.master.TestMasterTransiti= ons, org.apache.hadoop.hbase.rest.TestStatusResource, org.apache.hadoop.hba= se.client.TestFromClientSide, org.apache.hadoop.hbase.TestMultiParallelPut,= org.apache.hadoop.hbase.master.TestRegionManager, org.apache.hadoop.hbase.= mapreduce.TestTimeRangeMapRed > = > = > Thanks, > = > Benoit > = >