Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 16440 invoked from network); 10 Jun 2010 04:47:28 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 10 Jun 2010 04:47:28 -0000 Received: (qmail 84759 invoked by uid 500); 10 Jun 2010 04:40:48 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 84732 invoked by uid 500); 10 Jun 2010 04:40:47 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Delivered-To: moderator for dev@hbase.apache.org Received: (qmail 48199 invoked by uid 99); 10 Jun 2010 01:03:26 -0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,FREEMAIL_FROM,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: 75.101.130.251 is neither permitted nor denied by domain of jeff.hammerbacher@gmail.com) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-2400: new connector for Avro RPC access to HBase cluster From: "Jeff Hammerbacher" To: "Jeff Hammerbacher" , "Ryan Rawson" , jiraposter@review.hbase.org, dev@hbase.apache.org Date: Thu, 10 Jun 2010 01:03:00 -0000 Message-ID: <20100610010300.27729.75129@ip-10-250-218-255.ec2.internal> In-Reply-To: <20100610005420.27731.86639@ip-10-250-218-255.ec2.internal> References: <20100610005420.27731.86639@ip-10-250-218-255.ec2.internal> > On 2010-06-09 17:54:20, Ryan Rawson wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 111 > > > > > > do we need to make these fields nullable? usually they are true/fa= lse in the java code. = > > = > > Is this some semi-mechanical translation from a java api? I use the same Avro record for table creation and modification as well as d= escription. For create table, I want the fields to be nullable because the = user should not have to specify a value. > On 2010-06-09 17:54:20, Ryan Rawson wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 94 > > > > > > the compression can never be null, because the "NONE" is the catch = all here. Same as below: I use the same record for family creation, modification, and= description. Avro currently doesn't have default values on write, so makin= g this field nullable means we can do smart things if the user doesn't spec= ify a compression algorithm during Family creation. > On 2010-06-09 17:54:20, Ryan Rawson wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 78 > > > > > > same as deadServerNames. Yeah I should make these 0-length arrays. > On 2010-06-09 17:54:20, Ryan Rawson wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 73 > > > > > > couldnt you use a empty string if there are no dead server names? = im not sure if arrays can be 0 length in avro :-) Will make a 0-length array > On 2010-06-09 17:54:20, Ryan Rawson wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 66 > > > > > > technically the serverName is the serverAddress + startCode... in t= he Java code is isnt fully exposed. Not sure what we want to do here, but = this is probably fine as is. Yeah since Avro records don't have methods, you can think of this field as = a materialization of the Java logic. > On 2010-06-09 17:54:20, Ryan Rawson wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 34 > > > > > > you can probably just use 'hostname' and 'port'. There was a recen= t patch in trunk that is attempting to get rid of IP addresses (they cause = issues when they dont align with DNS names, etc) and generally move us to a= DNS name world. Let me know what you want me to do here. I was just copying the fields dire= ctly from the Java objects. - Jeff ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/128/#review164 ----------------------------------------------------------- On 2010-06-08 20:05:01, Jeff Hammerbacher wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/128/ > ----------------------------------------------------------- > = > (Updated 2010-06-08 20:05:01) > = > = > Review request for hbase. > = > = > Summary > ------- > = > Initial patch; some javadoc and tests missing, but I wanted to get some i= nitial feedback on the approach. My apologies for sticking a patch on the J= IRA before the review. I should have read further on the HowToContribute JI= RA. > = > = > This addresses bug HBASE-2400. > = > = > Diffs > ----- > = > trunk/bin/hbase 952782 = > trunk/pom.xml 952782 = > trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java PRE-CR= EATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java PRE-CREA= TION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AAlreadyExis= ts.java PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AClusterStat= us.java PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AColumn.java= PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AColumnFamil= yDescriptor.java PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AColumnValue= .java PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ACompression= Algorithm.java PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ADelete.java= PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AFamilyDescr= iptor.java PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AGet.java PR= E-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AIOError.jav= a PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AIllegalArgu= ment.java PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AMasterNotRu= nning.java PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/APut.java PR= E-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ARegionLoad.= java PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AResult.java= PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AResultEntry= .java PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AScan.java P= RE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AServerAddre= ss.java PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AServerInfo.= java PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AServerLoad.= java PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ATableDescri= ptor.java PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ATableExists= .java PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ATimeRange.j= ava PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/HBase.java P= RE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/IOError.java= PRE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/TCell.java P= RE-CREATION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.avpr PRE-CREATIO= N = > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro PRE-CREA= TION = > trunk/src/main/java/org/apache/hadoop/hbase/avro/package.html PRE-CREAT= ION = > trunk/src/test/java/org/apache/hadoop/hbase/avro/TestAvroServer.java PR= E-CREATION = > = > Diff: http://review.hbase.org/r/128/diff > = > = > Testing > ------- > = > = > Thanks, > = > Jeff > = >