Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 21598 invoked from network); 7 Jun 2010 20:26:54 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 7 Jun 2010 20:26:54 -0000 Received: (qmail 82924 invoked by uid 500); 7 Jun 2010 20:26:54 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 82831 invoked by uid 500); 7 Jun 2010 20:26:54 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 82819 invoked by uid 99); 7 Jun 2010 20:26:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Jun 2010 20:26:54 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,FREEMAIL_FROM,MIME_QP_LONG_LINE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 75.101.130.251 is neither permitted nor denied by domain of tsunanet@gmail.com) Received: from [75.101.130.251] (HELO ip-10-250-218-255.ec2.internal) (75.101.130.251) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Jun 2010 20:26:47 +0000 Received: from ip-10-250-218-255.ec2.internal (localhost.localdomain [127.0.0.1]) by ip-10-250-218-255.ec2.internal (Postfix) with ESMTP id 81FC9EE26; Mon, 7 Jun 2010 20:26:26 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-2618 Don't inherit from HConstants. From: "Benoit Sigoure" To: "Jonathan Gray" , "Ryan Rawson" , jiraposter@review.hbase.org, dev@hbase.apache.org, "Benoit Sigoure" Date: Mon, 07 Jun 2010 20:26:26 -0000 Message-ID: <20100607202626.27731.18775@ip-10-250-218-255.ec2.internal> In-Reply-To: <20100606064711.27731.3185@ip-10-250-218-255.ec2.internal> References: <20100606064711.27731.3185@ip-10-250-218-255.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/132/ ----------------------------------------------------------- (Updated 2010-06-07 13:26:26.467579) Review request for hbase. Changes ------- New version with coding style fixes and also HConstants becomes a "public f= inal class" instead of an "interface". Summary ------- HBASE-2618 Don't inherit from HConstants. Bonus: minor aesthetic / coding style clean ups and minor code changes. This addresses bug HBASE-2618. Diffs (updated) ----- trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java 951935 = trunk/src/main/java/org/apache/hadoop/hbase/HMerge.java 951935 = trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 951935 = trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.jav= a 951935 = trunk/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 95193= 5 = trunk/src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java 95193= 5 = trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 951935 = trunk/src/main/java/org/apache/hadoop/hbase/master/RegionManager.java 951= 935 = trunk/src/main/java/org/apache/hadoop/hbase/master/RegionServerOperation.= java 951935 = trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 951= 935 = trunk/src/main/java/org/apache/hadoop/hbase/master/TableOperation.java 95= 1935 = trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThre= ad.java 951935 = trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 951= 935 = trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.ja= va 951935 = trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 95193= 5 = trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 9= 51935 = trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 95= 1935 = trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java 95= 1935 = trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java 9= 51935 = trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.ja= va 951935 = trunk/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 951935 = trunk/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java 95= 1935 = trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColu= mnTracker.java 951935 = trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAt= OrBefore.java 951935 = trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetDeleteTra= cker.java 951935 = trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeyValueHeap= .java 951935 = trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestQueryMatcher= .java 951935 = trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanDeleteTr= acker.java 951935 = trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestWildcardColu= mnTracker.java 951935 = trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.jav= a 951935 = Diff: http://review.hbase.org/r/132/diff Testing ------- Code compiles. Tests are acting up on my machine right now (many of them fail with a weird= message [1] and Todd says he's been seeing similar failures for some time = already, so I guess I'll try to run them again next week when the New Moon = arrives). [1] A number of tests fail with: org.apache.hadoop.hbase.client.NoServerForRegionException: Timed out trying= to locate root region because: Failed setting up proxy to /192.168.0.7:637= 73 after attempts=3D1 at org.apache.hadoop.hbase.client.HConnectionManager$TableServers.l= ocateRootRegion(HConnectionManager.java:1031) Where, of course, 192.168.0.7 is my IP address. Some of the tests that are acting up: org.apache.hadoop.hbase.TestZooKeeper, org.apache.hadoop.hbase.regionserver= .wal.TestLogRolling, org.apache.hadoop.hbase.rest.TestScannersWithFilters, = org.apache.hadoop.hbase.master.TestMasterWrongRS, org.apache.hadoop.hbase.t= hrift.TestThriftServer, org.apache.hadoop.hbase.master.TestMasterTransition= s, org.apache.hadoop.hbase.rest.TestStatusResource, org.apache.hadoop.hbase= .client.TestFromClientSide, org.apache.hadoop.hbase.TestMultiParallelPut, o= rg.apache.hadoop.hbase.master.TestRegionManager, org.apache.hadoop.hbase.ma= preduce.TestTimeRangeMapRed Thanks, Benoit