Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 91611 invoked from network); 3 Jun 2010 19:54:16 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 3 Jun 2010 19:54:16 -0000 Received: (qmail 67625 invoked by uid 500); 3 Jun 2010 19:54:16 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 67474 invoked by uid 500); 3 Jun 2010 19:54:15 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 67466 invoked by uid 99); 3 Jun 2010 19:54:15 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jun 2010 19:54:15 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 75.101.130.251 is neither permitted nor denied by domain of stack@duboce.net) Received: from [75.101.130.251] (HELO ip-10-250-218-255.ec2.internal) (75.101.130.251) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jun 2010 19:54:09 +0000 Received: from ip-10-250-218-255.ec2.internal (localhost.localdomain [127.0.0.1]) by ip-10-250-218-255.ec2.internal (Postfix) with ESMTP id A3FB3EE20; Thu, 3 Jun 2010 19:53:48 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-2651 allow specifying non-tab separators in ImportTSV From: stack@duboce.net To: "Jonathan Gray" Date: Thu, 03 Jun 2010 19:53:48 -0000 Message-ID: <20100603195348.7374.1406@ip-10-250-218-255.ec2.internal> Cc: jiraposter@review.hbase.org, "Todd Lipcon" , dev@hbase.apache.org, stack@duboce.net In-Reply-To: <20100603193908.7402.86854@ip-10-250-218-255.ec2.internal> References: <20100603193908.7402.86854@ip-10-250-218-255.ec2.internal> X-Virus-Checked: Checked by ClamAV on apache.org ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/116/#review126 ----------------------------------------------------------- Ship it! +1 I reviewed this already but seems like review board lost my review. - stack On 2010-06-03 12:39:07, Todd Lipcon wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/116/ > ----------------------------------------------------------- > = > (Updated 2010-06-03 12:39:07) > = > = > Review request for hbase and Jonathan Gray. > = > = > Summary > ------- > = > Pretty self explanatory. > = > = > This addresses bug HBASE-2651. > http://issues.apache.org/jira/browse/HBASE-2651 > = > = > Diffs > ----- > = > src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java 32ba01d = > src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsv.java 612b= 00a = > = > Diff: http://review.hbase.org/r/116/diff > = > = > Testing > ------- > = > = > Thanks, > = > Todd > = >