hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: HBASE-2803 Remove remaining Get code from Store.java, etc
Date Tue, 29 Jun 2010 16:50:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/240/#review290
-----------------------------------------------------------



src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStore.java
<http://review.hbase.org/r/240/#comment1313>

    Can we not migrate these tests?  They look good.



src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStore.java
<http://review.hbase.org/r/240/#comment1314>

    Yeah, these are good tests.


- stack


On 2010-06-29 09:30:27, Ryan Rawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/240/
> -----------------------------------------------------------
> 
> (Updated 2010-06-29 09:30:27)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> Remove remaining Get code from Store.java,etc
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 40205c4 
>   src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java 7eac029 
>   src/main/java/org/apache/hadoop/hbase/regionserver/ReadWriteConsistencyControl.java
574e88a 
>   src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 9c720b1 
>   src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java d865e38 
>   src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java 9c1c95c

>   src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 48b8ac0 
>   src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStore.java 4f27ea5 
>   src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java b15ae53 
> 
> Diff: http://review.hbase.org/r/240/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryan
> 
>


Mime
View raw message