hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: Cache flush should go to tmp dir
Date Tue, 22 Jun 2010 07:14:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/216/#review261
-----------------------------------------------------------

Ship it!


+1 (if it passes all tests).  Nit-picks below.


src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
<http://review.hbase.org/r/216/#comment1110>

    ? There was notion of a '_tmp' already?
    
    I'd say name it '.tmp'... since a '.' prefix seems to be our convention given logs dir
at top-level has a '.' prefix.



src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
<http://review.hbase.org/r/216/#comment1111>

    Why not keep old name and just move dirs?  Why create a new unique name?



src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
<http://review.hbase.org/r/216/#comment1112>

    Nice test.


- stack


On 2010-06-21 23:57:39, Todd Lipcon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/216/
> -----------------------------------------------------------
> 
> (Updated 2010-06-21 23:57:39)
> 
> 
> Review request for hbase, stack and Ryan Rawson.
> 
> 
> Summary
> -------
> 
> Fixes bugs where an exception in the middle of flushing a file leaves a half-written
StoreFile in the region dir, preventing that region from recovering, or, in the case of transient
errors, causing silent loss of half a file's worth of data.
> 
> I also got rid of the compaction dir here, and am just using one region-wide tmp dir.
Is there some reason this is a bad idea?
> 
> 
> This addresses bug HBASE-2729.
>     http://issues.apache.org/jira/browse/HBASE-2729
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1794df8 
>   src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 04b7522 
>   src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java 9e5ca46 
>   src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java a65e947 
> 
> Diff: http://review.hbase.org/r/216/diff
> 
> 
> Testing
> -------
> 
> Ran TestCompaction and TestStore. Will start a cluster test running before I go to bed.
> 
> 
> Thanks,
> 
> Todd
> 
>


Mime
View raw message