hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans" <jdcry...@apache.org>
Subject Re: Review Request: Shutdown hook management is gone in trunk; restore
Date Wed, 16 Jun 2010 22:50:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/187/#review244
-----------------------------------------------------------

Ship it!


Looks good to me, nice cleanup compared to branch!

- Jean-Daniel


On 2010-06-16 15:06:36, stack wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/187/
> -----------------------------------------------------------
> 
> (Updated 2010-06-16 15:06:36)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> Adds a ShutdownHook class that is package private to regionserver.  Manages the running
of the regionserver shutdown before running the fs shutdown hook.  New class has a main so
its easy to check stuff works against the different hadoops; 0.20, 0.21 and cloudera 0.20.
> 
> 
> This addresses bug hbase-2725.
>     http://issues.apache.org/jira/browse/hbase-2725
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java fe9aa8a 
>   src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java PRE-CREATION 
>   src/main/java/org/apache/hadoop/hbase/regionserver/Stoppable.java PRE-CREATION 
>   src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 479c661 
> 
> Diff: http://review.hbase.org/r/187/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> stack
> 
>


Mime
View raw message