hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: HBASE-2670. Memstore should retain multiple versions of a row when memstore TS differs
Date Wed, 16 Jun 2010 04:13:47 GMT


> On 2010-06-15 18:06:09, Ryan Rawson wrote:
> > src/main/java/org/apache/hadoop/hbase/KeyValue.java, line 1306
> > <http://review.hbase.org/r/180/diff/1/?file=1345#file1345line1306>
> >
> >     the extra KVs will make it out to hfile, but considering the problem I just
don't see a better solution right now. Perhaps collapsing extra version during the flush,
but then the question is _which_ extra versions?
> >     
> >     Maybe this will lead us to using an extra timestamp in every KeyValue on disk
and in memory, but I hope not.

.bq ...but then the question is _which_ extra versions?

For now, I'd think we'd keep most recently written.

.bq Maybe this will lead us to using an extra timestamp in every KeyValue on disk and in memory

Maybe.  When we tease out deletes and how ts's are meant to work then we'll learn whether
or not they are needed I'd imagine.


- stack


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/180/#review235
-----------------------------------------------------------


On 2010-06-14 16:30:30, Todd Lipcon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/180/
> -----------------------------------------------------------
> 
> (Updated 2010-06-14 16:30:30)
> 
> 
> Review request for hbase and Ryan Rawson.
> 
> 
> Summary
> -------
> 
> This changes the memstore comparator, improves the atomicity tests, and also fixes ICV
to continue to have the right behavior even with the comparator change.
> 
> 
> This addresses bug hbase-2670.
>     http://issues.apache.org/jira/browse/hbase-2670
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/KeyValue.java 71284cf 
>   src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 2a0dcee 
>   src/test/java/org/apache/hadoop/hbase/MultithreadedTestUtil.java 7c062d7 
>   src/test/java/org/apache/hadoop/hbase/TestAcidGuarantees.java 75f3c8b 
>   src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStore.java 9833d76 
>   src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java 0566af7 
> 
> Diff: http://review.hbase.org/r/180/diff
> 
> 
> Testing
> -------
> 
> Unit tests.
> 
> 
> Thanks,
> 
> Todd
> 
>


Mime
View raw message