hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray" <jg...@apache.org>
Subject Re: Review Request: HBASE-2733 fix broken replacement of LATEST_TIMESTAMP in HRegion
Date Tue, 15 Jun 2010 22:30:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/183/#review232
-----------------------------------------------------------

Ship it!


lgtm


src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.hbase.org/r/183/#comment1035>

    nitpick to drop return from javadoc


- Jonathan


On 2010-06-15 15:25:55, Todd Lipcon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/183/
> -----------------------------------------------------------
> 
> (Updated 2010-06-15 15:25:55)
> 
> 
> Review request for hbase, stack and Ryan Rawson.
> 
> 
> Summary
> -------
> 
> I broke this in HBASE-2353 so it only worked with writeToWAL==true. This fixes and adds
unit test. Also fixes TestGetClosestBefore
> 
> 
> This addresses bug HBASE-2733.
>     http://issues.apache.org/jira/browse/HBASE-2733
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 06e022c 
>   src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 1c1cd4b 
> 
> Diff: http://review.hbase.org/r/183/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Todd
> 
>


Mime
View raw message