hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Hammerbacher" <jeff.hammerbac...@gmail.com>
Subject Re: Review Request: HBASE-2400: new connector for Avro RPC access to HBase cluster
Date Sat, 12 Jun 2010 05:56:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/128/
-----------------------------------------------------------

(Updated 2010-06-11 22:56:49.438699)


Review request for hbase.


Changes
-------

Hey, I've added more tests and addressed all of the review comments. Any chance we can get
this into trunk? I'd like to start addressing some of the follow-on issues.


Summary
-------

Initial patch; some javadoc and tests missing, but I wanted to get some initial feedback on
the approach. My apologies for sticking a patch on the JIRA before the review. I should have
read further on the HowToContribute JIRA.


This addresses bug HBASE-2400.
    http://issues.apache.org/jira/browse/HBASE-2400


Diffs (updated)
-----

  trunk/bin/hbase 953940 
  trunk/pom.xml 953940 
  trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AAlreadyExists.java PRE-CREATION

  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AClusterStatus.java PRE-CREATION

  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AColumn.java PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AColumnFamilyDescriptor.java
PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AColumnValue.java PRE-CREATION

  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ACompressionAlgorithm.java PRE-CREATION

  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ADelete.java PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AFamilyDescriptor.java PRE-CREATION

  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AGet.java PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AIOError.java PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AIllegalArgument.java PRE-CREATION

  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AMasterNotRunning.java PRE-CREATION

  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/APut.java PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ARegionLoad.java PRE-CREATION

  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AResult.java PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AResultEntry.java PRE-CREATION

  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AScan.java PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AServerAddress.java PRE-CREATION

  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AServerInfo.java PRE-CREATION

  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AServerLoad.java PRE-CREATION

  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ATableDescriptor.java PRE-CREATION

  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ATableExists.java PRE-CREATION

  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ATimeRange.java PRE-CREATION

  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/HBase.java PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/IOError.java PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/TCell.java PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.avpr PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro PRE-CREATION 
  trunk/src/main/java/org/apache/hadoop/hbase/avro/package.html PRE-CREATION 
  trunk/src/test/java/org/apache/hadoop/hbase/avro/TestAvroServer.java PRE-CREATION 

Diff: http://review.hbase.org/r/128/diff


Testing
-------


Thanks,

Jeff


Mime
View raw message