hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: HBASE-2223
Date Fri, 11 Jun 2010 19:45:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/76/#review191
-----------------------------------------------------------


I got as far as ReplicationLogCleaner... will continue later.


bin/replication/add_peer.rb
<http://review.hbase.org/r/76/#comment868>

    Should you point at some replication documentation here?  Is there such a thing?



bin/replication/copy_tables_desc.rb
<http://review.hbase.org/r/76/#comment870>

    This could get a bit annoying I'd say.



src/main/java/org/apache/hadoop/hbase/HConstants.java
<http://review.hbase.org/r/76/#comment871>

    This has to go here?  Can it go into one of the replication classes?



src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
<http://review.hbase.org/r/76/#comment872>

    Can't you just do c.get("key", defaultvalue)?



src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<http://review.hbase.org/r/76/#comment873>

    You writing startcode into zk?  Why not write servername -- the host+port+startcode combo?



src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
<http://review.hbase.org/r/76/#comment875>

    Is this directory name?  Confusingly named given rootdir+regLogPathStr only adds up to
repLogPath.



src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment876>

    Replication needs package documentation or else an article (like metrics) -- oh, i see
it later... nm



src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment877>

    Peers are named '1', '2'?  Can't we have more meaningful names here?



src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment878>

    s/replicates/replicate/
    



src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment879>

    Use servername instead of startcode



src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment880>

    All RS's in a master cluster replicate?



src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment881>

    Should this class be called WRapper instaad of Helper?



src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment882>

    Registers it where?



src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment883>

    You mean 'ensemble' here rather than 'quorum' (Patrick will kill you if he sees you calling
it a 'quorum' when you mean the other)



src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment884>

    We keep up the replication position in zk?  How much do we replicate in one go?  Its not
a single edit, is it?  We do this for every log file?



src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment885>

    LOG.warn instead?
    



src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment887>

    We return empty map if clusters size is == 1?  Should that be clusters.size == 0?



src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment886>

    Whats this about?



src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java
<http://review.hbase.org/r/76/#comment888>

    Just logging errors?  What if session expired (our discussion from last day)?



src/main/java/org/apache/hadoop/hbase/replication/package.html
<http://review.hbase.org/r/76/#comment889>

    Call it alpha



src/main/java/org/apache/hadoop/hbase/replication/package.html
<http://review.hbase.org/r/76/#comment890>

    Whats this about?  You need to run zk yourself but no zoo.cfg?



src/main/java/org/apache/hadoop/hbase/replication/package.html
<http://review.hbase.org/r/76/#comment891>

    And if not?  What if replicating single-family only?



src/main/java/org/apache/hadoop/hbase/replication/package.html
<http://review.hbase.org/r/76/#comment892>

    Has to be offline?  Will this always be the case?



src/main/java/org/apache/hadoop/hbase/replication/package.html
<http://review.hbase.org/r/76/#comment893>

    whats ratio?


- stack


On 2010-06-08 17:54:19, Jean-Daniel Cryans wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/76/
> -----------------------------------------------------------
> 
> (Updated 2010-06-08 17:54:19)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> This is HBASE-2223 AKA Replication 2.0, it is currently only a "preview patch" as it's
pretty much feature complete, works on a cluster, has unit tests and whatnot, but it could
use a lot more testing and cleaning and ideas from others.
> 
> 
> This addresses bug HBASE-2223.
>     http://issues.apache.org/jira/browse/HBASE-2223
> 
> 
> Diffs
> -----
> 
>   bin/replication/add_peer.rb PRE-CREATION 
>   bin/replication/copy_tables_desc.rb PRE-CREATION 
>   pom.xml 03c6ec8 
>   src/main/java/org/apache/hadoop/hbase/HConstants.java 13aff26 
>   src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java b36f1df 
>   src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 82148a6 
>   src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java a1baff4 
>   src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 034690e 
>   src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java 5d4cffe 
>   src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java PRE-CREATION

>   src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java
PRE-CREATION 
>   src/main/java/org/apache/hadoop/hbase/replication/package.html PRE-CREATION 
>   src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
PRE-CREATION 
>   src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
PRE-CREATION 
>   src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java
PRE-CREATION 
>   src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
PRE-CREATION 
>   src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 2f2f306 
>   src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java PRE-CREATION

>   src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java PRE-CREATION

>   src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java PRE-CREATION

>   src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
PRE-CREATION 
>   src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java
PRE-CREATION 
> 
> Diff: http://review.hbase.org/r/76/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jean-Daniel
> 
>


Mime
View raw message