hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon" <t...@cloudera.com>
Subject Re: Review Request: hbase-2208, a simple fix
Date Fri, 11 Jun 2010 17:31:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/165/#review187
-----------------------------------------------------------

Ship it!


+1, lgtm. I didn't realize that HBase's hacked version of IPC does indeed support Lists in
trunk. And your point about avoiding a shallow copy makes good sense.

- Todd


On 2010-06-10 21:32:57, stack wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/165/
> -----------------------------------------------------------
> 
> (Updated 2010-06-10 21:32:57)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> Patch that changes interface for batch put and delete so passes List instead of an array.
> 
> Straight-forward change but for some generics wrestling and some gratuitous eclipse reformatting
of imports.
> 
> 
> This addresses bug hbase-2208.
>     http://issues.apache.org/jira/browse/hbase-2208
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java ed18092 
>   src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java b36f1df 
>   src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java a1baff4 
> 
> Diff: http://review.hbase.org/r/165/diff
> 
> 
> Testing
> -------
> 
> Tests pass but testzookeeper (something broke this).
> 
> 
> Thanks,
> 
> stack
> 
>


Mime
View raw message