hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: Batch writes should sync to HLog in batches
Date Fri, 11 Jun 2010 16:59:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/167/#review181
-----------------------------------------------------------

Ship it!


Looks good to me.  Minor comments below.


src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.hbase.org/r/167/#comment848>

    Should this be public?  Isn't it just used internally?



src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.hbase.org/r/167/#comment847>

    Is this a copy?



src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.hbase.org/r/167/#comment849>

    You were going to replace these w/ something from guava (or is this it?)



src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.hbase.org/r/167/#comment850>

    Same here



src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.hbase.org/r/167/#comment851>

    This creates new Map, pass in Map.Entry instead?



src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.hbase.org/r/167/#comment852>

    I hate that this is even an option (smile)



src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.hbase.org/r/167/#comment853>

    w can never be null here?  (There was null check previous)



src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.hbase.org/r/167/#comment854>

    Missing javadoc on new param


- stack


On 2010-06-11 00:50:05, Todd Lipcon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/167/
> -----------------------------------------------------------
> 
> (Updated 2010-06-11 00:50:05)
> 
> 
> Review request for hbase, Kannan Muthukkaruppan and Ryan Rawson.
> 
> 
> Summary
> -------
> 
> I implemented the "mini batching" idea we talked about on the JIRA.
> 
> This currently breaks some of the error handling, so I dont intend to commit as is, but
everyone is busy so wanted to put a review up now while I tidy up the rest.
> 
> 
> This addresses bug HBASE-2353.
>     http://issues.apache.org/jira/browse/HBASE-2353
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6b6d098 
>   src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java a1baff4 
>   src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 034690e 
> 
> Diff: http://review.hbase.org/r/167/diff
> 
> 
> Testing
> -------
> 
> Some PEs on a real sync-enabled cluster, seems faster but haven't done scientific benchmarking.
> 
> 
> Thanks,
> 
> Todd
> 
>


Mime
View raw message