hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon" <t...@cloudera.com>
Subject Review Request: Batch writes should sync to HLog in batches
Date Fri, 11 Jun 2010 07:50:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/167/
-----------------------------------------------------------

Review request for hbase, Kannan Muthukkaruppan and Ryan Rawson.


Summary
-------

I implemented the "mini batching" idea we talked about on the JIRA.

This currently breaks some of the error handling, so I dont intend to commit as is, but everyone
is busy so wanted to put a review up now while I tidy up the rest.


This addresses bug HBASE-2353.
    http://issues.apache.org/jira/browse/HBASE-2353


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6b6d098 
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java a1baff4 
  src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 034690e 

Diff: http://review.hbase.org/r/167/diff


Testing
-------

Some PEs on a real sync-enabled cluster, seems faster but haven't done scientific benchmarking.


Thanks,

Todd


Mime
View raw message