hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: TestMasterWrongRS flaky in trunk
Date Tue, 08 Jun 2010 21:40:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/163/#review158
-----------------------------------------------------------

Ship it!


+1 after making below suggested fix.


/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterWrongRS.java
<http://review.hbase.org/r/163/#comment791>

    This looks wrong.  Shouldn't the index be '1' for the second server?  Its the index you
used at start of the test to get reference to seconServer.
    
    Otherwise, looks good.. go ahead and commit


- stack


On 2010-06-08 14:27:28, Jean-Daniel Cryans wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/163/
> -----------------------------------------------------------
> 
> (Updated 2010-06-08 14:27:28)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> Patch that uses MiniHBaseCluster.waitOnRegionServer instead of sleeping, and adds a timeout
to the test.
> 
> 
> This addresses bug HBASE-2684.
> 
> 
> Diffs
> -----
> 
>   /trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterWrongRS.java 952744 
> 
> Diff: http://review.hbase.org/r/163/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jean-Daniel
> 
>


Mime
View raw message