hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: HBASE-1748 ClusterStatus needs to print out who has master role
Date Tue, 08 Jun 2010 21:36:04 GMT


> On 2010-06-07 14:48:27, stack wrote:
> > src/main/java/org/apache/hadoop/hbase/ClusterStatus.java, line 40
> > <http://review.hbase.org/r/162/diff/1/?file=1056#file1056line40>
> >
> >     Should it be hosname rather than ip?
> 
> Lars George wrote:
>     The reason is that when the ZooKeeper node is created an IP address is stored, not
the hostname. After that it is all IP based by the looks. I am reading from the ZK node using
ZKW and it sticks with the IP representation. Should we change all that?

I think so.  In separate issue as you suggest.  Add port too so can do many masters on single
node if only for testing.


> On 2010-06-07 14:48:27, stack wrote:
> > src/main/java/org/apache/hadoop/hbase/util/MasterLocatorFilter.java, line 41
> > <http://review.hbase.org/r/162/diff/1/?file=1059#file1059line41>
> >
> >     Should this filter go into the master webapp?
> 
> Lars George wrote:
>     I put it next to InfoServer where it is used. What are you suggesting? I think I
am misreading your comment, could you elaborate?

OK.  Forgot infoserver was in util.  I was thinking of putting filter under src/main/resources/webapps
or whatever its called into the master subdir... but that is probably more pain than its worth
since we're expecting only jsp there (I suppose you could do the filter in jsp -- but now
I'm being silly).... Leave it where it is Lars.


- stack


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/162/#review145
-----------------------------------------------------------


On 2010-06-07 23:55:54, Lars George wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/162/
> -----------------------------------------------------------
> 
> (Updated 2010-06-07 23:55:54)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> HBASE-1748 ClusterStatus needs to print out who has master role
> 
> Please have a look, I was not able to test (yet) on a single machine. Will try on cluster
later but wanted to get a quick feedback. 
> 
> Also upped VERSION in ClusterStatus, is that OK or not needed?
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/ClusterStatus.java d102643 
>   src/main/java/org/apache/hadoop/hbase/master/HMaster.java 5946eee 
>   src/main/java/org/apache/hadoop/hbase/util/InfoServer.java 7a3d4f9 
>   src/main/java/org/apache/hadoop/hbase/util/MasterLocatorFilter.java PRE-CREATION 
> 
> Diff: http://review.hbase.org/r/162/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lars
> 
>


Mime
View raw message