hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@duboce.net
Subject Re: Review Request: HBASE-1748 ClusterStatus needs to print out who has master role
Date Tue, 08 Jun 2010 19:53:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/162/#review157
-----------------------------------------------------------

Ship it!


+1

Add issue to change master to use hostname instead of ip too please.

- stack


On 2010-06-07 23:55:54, Lars George wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/162/
> -----------------------------------------------------------
> 
> (Updated 2010-06-07 23:55:54)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> HBASE-1748 ClusterStatus needs to print out who has master role
> 
> Please have a look, I was not able to test (yet) on a single machine. Will try on cluster
later but wanted to get a quick feedback. 
> 
> Also upped VERSION in ClusterStatus, is that OK or not needed?
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/ClusterStatus.java d102643 
>   src/main/java/org/apache/hadoop/hbase/master/HMaster.java 5946eee 
>   src/main/java/org/apache/hadoop/hbase/util/InfoServer.java 7a3d4f9 
>   src/main/java/org/apache/hadoop/hbase/util/MasterLocatorFilter.java PRE-CREATION 
> 
> Diff: http://review.hbase.org/r/162/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lars
> 
>


Mime
View raw message