hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars George" <larsgeo...@apache.org>
Subject Re: Review Request: HBASE-1748 ClusterStatus needs to print out who has master role
Date Tue, 08 Jun 2010 06:55:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/162/
-----------------------------------------------------------

(Updated 2010-06-07 23:55:54.560518)


Review request for hbase.


Changes
-------

This is v2 of the patch with the discussed changes:

- change ClusterStatus to implement Writable
- Fix webapp renaming

I also changed it so that activeMaster is never null so that it can be used in hashcode()
etc. safely.


Summary
-------

HBASE-1748 ClusterStatus needs to print out who has master role

Please have a look, I was not able to test (yet) on a single machine. Will try on cluster
later but wanted to get a quick feedback. 

Also upped VERSION in ClusterStatus, is that OK or not needed?


Diffs (updated)
-----

  src/main/java/org/apache/hadoop/hbase/ClusterStatus.java d102643 
  src/main/java/org/apache/hadoop/hbase/master/HMaster.java 5946eee 
  src/main/java/org/apache/hadoop/hbase/util/InfoServer.java 7a3d4f9 
  src/main/java/org/apache/hadoop/hbase/util/MasterLocatorFilter.java PRE-CREATION 

Diff: http://review.hbase.org/r/162/diff


Testing
-------


Thanks,

Lars


Mime
View raw message