hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell" <apurt...@apache.org>
Subject Re: Review Request: HBASE-1748 ClusterStatus needs to print out who has master role
Date Mon, 07 Jun 2010 22:10:47 GMT


> On 2010-06-07 14:54:04, Andrew Purtell wrote:
> > src/main/java/org/apache/hadoop/hbase/ClusterStatus.java, line 52
> > <http://review.hbase.org/r/162/diff/1/?file=1056#file1056line52>
> >
> >     Maybe this should not extend VersionedWritable in the first place. We don't
need and are not adhering to its contract.
> >     
> >     You don't support reading in version 0 serialization elsewhere.
> >     
> >     I cannot think of any circumstance where we would need to auto-upgrade serializations
of this struct.
> 
> Lars George wrote:
>     So nothing to change or leave it a 1?

Or inherit from Writable only and get rid of VERSION.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/162/#review146
-----------------------------------------------------------


On 2010-06-07 14:30:25, Lars George wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/162/
> -----------------------------------------------------------
> 
> (Updated 2010-06-07 14:30:25)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> HBASE-1748 ClusterStatus needs to print out who has master role
> 
> Please have a look, I was not able to test (yet) on a single machine. Will try on cluster
later but wanted to get a quick feedback. 
> 
> Also upped VERSION in ClusterStatus, is that OK or not needed?
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/ClusterStatus.java d102643 
>   src/main/java/org/apache/hadoop/hbase/master/HMaster.java 5946eee 
>   src/main/java/org/apache/hadoop/hbase/util/InfoServer.java 7a3d4f9 
>   src/main/java/org/apache/hadoop/hbase/util/MasterLocatorFilter.java PRE-CREATION 
> 
> Diff: http://review.hbase.org/r/162/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lars
> 
>


Mime
View raw message