hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell" <apurt...@apache.org>
Subject Re: Review Request: HBASE-2001 RegionObserver
Date Fri, 04 Jun 2010 04:50:03 GMT


> On 2010-06-02 17:24:34, Todd Lipcon wrote:
> > src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassloading.java, line 40
> > <http://review.hbase.org/r/96/diff/4/?file=898#file898line40>
> >
> >     woah, can we add something to the build to build this jar as a test resource,
or something?

Yes.


> On 2010-06-02 17:24:34, Todd Lipcon wrote:
> > src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java,
line 43
> > <http://review.hbase.org/r/96/diff/4/?file=899#file899line43>
> >
> >     you could use mockito verification to do this, probably would be simpler

Thanks this would be a good opportunity to learn mockito.


> On 2010-06-02 17:24:34, Todd Lipcon wrote:
> > src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java, line 149
> > <http://review.hbase.org/r/96/diff/4/?file=892#file892line149>
> >
> >     this map-like interface is somewhat confusing - what's the purpose of it?

This is an environment space, like unix process env vars, shared among all threads of the
coprocessor (which get a reference to the environment). Useful for the mapreduce stuff not
included in this patch. For example, rather than sum or average using intermediates, update
AtomicLongs instead.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/96/#review121
-----------------------------------------------------------


On 2010-05-31 22:47:25, Andrew Purtell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/96/
> -----------------------------------------------------------
> 
> (Updated 2010-05-31 22:47:25)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> This patch is the parts of the HBASE-2001 patch which implements support for the RegionObserver
interface. This enables extension of the regionserver through stacking dynamically loaded
classes i.e. from jars on HDFS onto upcalls from HRegion. I made some improvements over the
other patch and added a test case. There are other parts of 2001 which need some thought and
some work and would not be useful without client side support. This is the part which could
be immediately useful. 
> 
> Submitted for feedback. 
> 
> Incorporates a user suggestion and Stack +1 about hooking compaction.
> 
> 
> This addresses bug HBASE-2001.
>     http://issues.apache.org/jira/browse/HBASE-2001
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java PRE-CREATION 
>   src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java PRE-CREATION

>   src/main/java/org/apache/hadoop/hbase/regionserver/CoprocessorHost.java PRE-CREATION

>   src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 2413e98 
>   src/main/java/org/apache/hadoop/hbase/regionserver/MinorCompactingStoreScanner.java
71f738e 
>   src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 515b42f 
>   src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassloading.java PRE-CREATION

>   src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java PRE-CREATION

>   src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java
PRE-CREATION 
>   src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java PRE-CREATION

> 
> Diff: http://review.hbase.org/r/96/diff
> 
> 
> Testing
> -------
> 
> All the new unit tests plus TestHRegion pass locally.
> 
> 
> Thanks,
> 
> Andrew
> 
>


Mime
View raw message