hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon" <t...@cloudera.com>
Subject Re: Review Request: HBASE-2635. Fixes for ImmutableBytesWritable
Date Tue, 01 Jun 2010 20:38:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/110/#review110
-----------------------------------------------------------



src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java
<http://review.hbase.org/r/110/#comment662>

    Before we were hashing the entire byte array, not just the section of bytes corresponding
to this writable. So the hashcode could be different even if the sliced bytes were the same.
See new unit test for hashcode.


- Todd


On 2010-05-31 23:25:59, Todd Lipcon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/110/
> -----------------------------------------------------------
> 
> (Updated 2010-05-31 23:25:59)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> Various fixes + unit test
> 
> 
> This addresses bug HBASE-2635.
>     http://issues.apache.org/jira/browse/HBASE-2635
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/io/ImmutableBytesWritable.java 0a9ec4b 
>   src/test/java/org/apache/hadoop/hbase/io/TestImmutableBytesWritable.java 1e8886b 
> 
> Diff: http://review.hbase.org/r/110/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Todd
> 
>


Mime
View raw message