Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hbase.apache.org
Received-SPF: pass (nike.apache.org: domain of jgray@facebook.com designates
 69.63.179.25 as permitted sender)
From: Jonathan Gray <jgray@facebook.com>
To: "dev@hbase.apache.org" <dev@hbase.apache.org>
Date: Tue, 25 May 2010 23:44:41 -0700
Subject: RE: Review board for all/most JIRAs patches
Thread-Topic: Review board for all/most JIRAs patches
Thread-Index: Acr8ki33KboUOXthRZiXUiExIwdkogADLlfQ
Message-ID: 
 <8D66B74984F9564BBB25C3C67D630F2D68C7CEAF@SC-MBXC1.TheFacebook.com>
References: <AANLkTin5qgReMGpWlXVwWs67hDrEQzyYEls7KY6u24AO@mail.gmail.com>
 <AANLkTinsLvk7lpx8Qv02ckaQ19oK3qfDUXjUe-gWrJOR@mail.gmail.com>
In-Reply-To: <AANLkTinsLvk7lpx8Qv02ckaQ19oK3qfDUXjUe-gWrJOR@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Is any of this on the wiki?

> -----Original Message-----
> From: Ryan Rawson [mailto:ryanobjc@gmail.com]
> Sent: Tuesday, May 25, 2010 10:11 PM
> To: dev@hbase.apache.org
> Subject: Re: Review board for all/most JIRAs patches
>=20
> Everyone...
>=20
> This is working out great so far.
>=20
> Some clarifying guidelines:
>=20
> - Please post all patches to be reviewed to http://review.hbase.org
> - Only upload the final version, no need to put multiple patches on
> JIRA, only the "to be committed version"
> - If you already have a review and you just need to put up a patch for
> audit, feel free to just upload to JIRA
> - Please put the JIRA name and the short (eg: HBASE-1234 fix X Y Z)
>=20
> Thanks and happy coding!
> -ryan
>=20
> On Fri, May 21, 2010 at 3:56 PM, Ryan Rawson <ryanobjc@gmail.com>
> wrote:
> > Hi all,
> >
> > To make the life of reviewers easier, as well as improving review
> turn
> > around time, we are requesting all contributors (committers and
> > otherwise) to submit patches to http://review.hbase.org/ in addition
> > to attaching them to JIRAs. =A0Review board has a nice API which allows
> > people to review diffs without downloading a patch and applying it,
> > and it is source code aware and will allow a reviewer to expand the
> > context. =A0It works with both SVN diffs and GIT diffs for those who
> use
> > one or the other (or both) to develop their diffs. =A0(I have to
> > recommend git - it makes rebasing and keeping a patch current much
> > easier, especially with the latest trunk turmoil).
> >
> > If the patch is more than 2 files, please make everyone's life easier
> > by review boarding it!
> >
> > I'm checking to see if it is possible to have reviewboard's email
> > cause JIRA comments. =A0Hopefully it will and then we will have a full
> > record and a better UI.
> >
> > -ryan
> >