Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 45952 invoked from network); 28 May 2010 21:13:40 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 28 May 2010 21:13:40 -0000 Received: (qmail 86636 invoked by uid 500); 28 May 2010 21:13:40 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 86608 invoked by uid 500); 28 May 2010 21:13:40 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Received: (qmail 86600 invoked by uid 99); 28 May 2010 21:13:40 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 May 2010 21:13:40 +0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=AWL,FH_HELO_EQ_D_D_D_D,FREEMAIL_FROM,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: 75.101.130.251 is neither permitted nor denied by domain of tsunanet@gmail.com) Received: from [75.101.130.251] (HELO ip-10-250-10-165.ec2.internal) (75.101.130.251) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 May 2010 21:13:35 +0000 Received: from ip-10-250-10-165.ec2.internal (localhost.localdomain [127.0.0.1]) by ip-10-250-10-165.ec2.internal (Postfix) with ESMTP id 9C5BA20B76; Fri, 28 May 2010 21:13:14 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-2468: Improvements to prewarm META cache on clients. From: "Benoit Sigoure" To: "Mingjie Lai" , jiraposter@review.hbase.org, dev@hbase.apache.org, "Benoit Sigoure" Date: Fri, 28 May 2010 21:13:14 -0000 Message-ID: <20100528211314.13032.44086@ip-10-250-10-165.ec2.internal> In-Reply-To: <20100528202033.21168.44417@ip-10-250-10-165.ec2.internal> References: <20100528202033.21168.44417@ip-10-250-10-165.ec2.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/98/#review93 ----------------------------------------------------------- src/main/java/org/apache/hadoop/hbase/client/HConnection.java Properly document this argument. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Please use a concurrent collection and remove the synchronized blocks. = For guidance, see around slide 30 of this presentation: http://www.cs.umd.edu/class/fall2009/cmsc132H/slides/still-effective.pdf src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Coding style: put the catch on the previous line. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java We don't typically call methods using `this.methodname(args)' =E2=80=93= remove the `this.' src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Add a space before the `:'. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Use `Boolean.TRUE' instead of `new Boolean(true)'. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Use `Boolean.FALSE' instead of `new Boolean(false)'. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Use `Boolean.TRUE' instead of `new Boolean(true)'. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Remove the outer parentheses. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Add a space before the `:'. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java If this fits on the previous line while staying under 80 columns, pleas= e wrap it around. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Remove the space after `cacheLocation' src/main/java/org/apache/hadoop/hbase/client/HTable.java Use {@link #readFields readFields} instead of readFields src/main/java/org/apache/hadoop/hbase/client/HTable.java You can remove this

src/main/java/org/apache/hadoop/hbase/client/HTable.java Use 

 not 



src/main/java/org/apache/hadoop/hbase/client/HTable.java


    Add a space before the `:'.



src/main/java/org/apache/hadoop/hbase/client/HTable.java


    Use {@link #getRegionsInfo getRegionsInfo}



src/main/java/org/apache/hadoop/hbase/client/HTable.java


    Use {@link ...} here and below.



src/main/java/org/apache/hadoop/hbase/client/HTable.java


    Wrap this around with the previous line.



src/main/java/org/apache/hadoop/hbase/client/HTable.java


    I believe you can remove this block.


- Benoit


On 2010-05-28 13:20:33, Mingjie Lai wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/98/
> -----------------------------------------------------------
> =

> (Updated 2010-05-28 13:20:33)
> =

> =

> Review request for hbase.
> =

> =

> Summary
> -------
> =

> HBASE-2468: Improvements to prewarm META cache on clients.
> =

> Changes:
> 1. Add new HTable methods which support region info de/serialation, and r=
egion cache prewarm: =

> - void serializeRegionInfo(): clients could perform a large scan for all =
the meta for the table, serialize the meta to a file. MR job can ship a cop=
y of the meta for the table in the DistributedCache
> - Map deserializeRegionInfo(): MR job can de=
serialize the region info from the DistributedCache =

> - prewarmRegionCache(Map regionMap): MR job =
can prewarm local region cache by the deserialized region info.
> =

> 2. For each client, each region cache read-miss could trigger read-ahead =
some number of rows in META. This option could be turned on and off for one=
 particular table. =

> =

> =

> This addresses bug HBASE-2468.
>     http://issues.apache.org/jira/browse/HBASE-2468
> =

> =

> Diffs
> -----
> =

>   src/main/java/org/apache/hadoop/hbase/client/HConnection.java 853164d =

>   src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 09=
de2ac =

>   src/main/java/org/apache/hadoop/hbase/client/HTable.java 7ec95cb =

>   src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 3de661e =

>   src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java 95=
e494a =

> =

> Diff: http://review.hbase.org/r/98/diff
> =

> =

> Testing
> -------
> =

> Unit tests passed locally for me. =

> =

> =

> Thanks,
> =

> Mingjie
> =

>