Return-Path: Delivered-To: apmail-hbase-dev-archive@www.apache.org Received: (qmail 18762 invoked from network); 26 May 2010 23:29:05 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 26 May 2010 23:29:05 -0000 Received: (qmail 14321 invoked by uid 500); 26 May 2010 23:29:04 -0000 Delivered-To: apmail-hbase-dev-archive@hbase.apache.org Received: (qmail 14283 invoked by uid 500); 26 May 2010 23:29:04 -0000 Mailing-List: contact dev-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hbase.apache.org Delivered-To: mailing list dev@hbase.apache.org Delivered-To: moderator for dev@hbase.apache.org Received: (qmail 29906 invoked by uid 99); 26 May 2010 22:12:51 -0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=AWL,FH_HELO_EQ_D_D_D_D,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: Review Request: HBASE-2613 From: "Jean-Daniel Cryans" To: "Jean-Daniel Cryans" , jiraposter@review.hbase.org, "Todd Lipcon" , dev@hbase.apache.org Date: Wed, 26 May 2010 22:12:24 -0000 Message-ID: <20100526221224.20565.58813@ip-10-250-10-165.ec2.internal> In-Reply-To: <20100526001431.21168.62084@ip-10-250-10-165.ec2.internal> References: <20100526001431.21168.62084@ip-10-250-10-165.ec2.internal> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/89/ ----------------------------------------------------------- (Updated 2010-05-26 15:12:24.679274) Review request for hbase. Changes ------- New patch with test for master. Spawns a 3 nodes cluster, kills 2 by changi= ng the startcode and address. Summary ------- Patch that removes all the MSG_CALL_SERVER_STARTUP related code that was sc= rewing us more than helping us. Now, when a region server pings back with a= different start code, we just shut it down. This addresses bug HBASE-2613. Diffs (updated) ----- /trunk/src/main/java/org/apache/hadoop/hbase/HMsg.java 948611 = /trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 94= 8611 = /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.j= ava 948611 = /trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterWrongRS.jav= a PRE-CREATION = Diff: http://review.hbase.org/r/89/diff Testing ------- Thanks, Jean-Daniel