hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jonathan Gray <jg...@facebook.com>
Subject RE: Review board for all/most JIRAs patches
Date Wed, 26 May 2010 07:01:55 GMT
That would be awesome, Daniel.  Thanks for all the great work!

> -----Original Message-----
> From: Daniel Ploeg [mailto:dploeg@gmail.com]
> Sent: Tuesday, May 25, 2010 11:56 PM
> To: dev@hbase.apache.org
> Subject: Re: Review board for all/most JIRAs patches
> 
> Not all of this. I can update the HowToContribute page as I haven't
> closed out the Jira item for that task yet.
> 
> Sent from my iPhone
> 
> On 26/05/2010, at 4:44 PM, Jonathan Gray <jgray@facebook.com> wrote:
> 
> > Is any of this on the wiki?
> >
> >> -----Original Message-----
> >> From: Ryan Rawson [mailto:ryanobjc@gmail.com]
> >> Sent: Tuesday, May 25, 2010 10:11 PM
> >> To: dev@hbase.apache.org
> >> Subject: Re: Review board for all/most JIRAs patches
> >>
> >> Everyone...
> >>
> >> This is working out great so far.
> >>
> >> Some clarifying guidelines:
> >>
> >> - Please post all patches to be reviewed to http://review.hbase.org
> >> - Only upload the final version, no need to put multiple patches on
> >> JIRA, only the "to be committed version"
> >> - If you already have a review and you just need to put up a patch
> >> for
> >> audit, feel free to just upload to JIRA
> >> - Please put the JIRA name and the short (eg: HBASE-1234 fix X Y Z)
> >>
> >> Thanks and happy coding!
> >> -ryan
> >>
> >> On Fri, May 21, 2010 at 3:56 PM, Ryan Rawson <ryanobjc@gmail.com>
> >> wrote:
> >>> Hi all,
> >>>
> >>> To make the life of reviewers easier, as well as improving review
> >> turn
> >>> around time, we are requesting all contributors (committers and
> >>> otherwise) to submit patches to http://review.hbase.org/ in
> addition
> >>> to attaching them to JIRAs.  Review board has a nice API which
> >>> allows
> >>> people to review diffs without downloading a patch and applying it,
> >>> and it is source code aware and will allow a reviewer to expand the
> >>> context.  It works with both SVN diffs and GIT diffs for those who
> >> use
> >>> one or the other (or both) to develop their diffs.  (I have to
> >>> recommend git - it makes rebasing and keeping a patch current much
> >>> easier, especially with the latest trunk turmoil).
> >>>
> >>> If the patch is more than 2 files, please make everyone's life
> >>> easier
> >>> by review boarding it!
> >>>
> >>> I'm checking to see if it is possible to have reviewboard's email
> >>> cause JIRA comments.  Hopefully it will and then we will have a
> full
> >>> record and a better UI.
> >>>
> >>> -ryan
> >>>

Mime
View raw message